Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supporting content for ingesting-data-with-onelake-part-i #349

Merged
merged 3 commits into from
Jan 21, 2025
Merged

supporting content for ingesting-data-with-onelake-part-i #349

merged 3 commits into from
Jan 21, 2025

Conversation

llermaly
Copy link
Contributor

@llermaly llermaly commented Nov 2, 2024

No description provided.

@gitnotebooks GitNotebooks
Copy link

gitnotebooks bot commented Nov 2, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/349

@llermaly llermaly changed the title supporting content supporting content for ingesting-data-with-onelake-part-i Nov 2, 2024
@JessicaGarson
Copy link
Contributor

@llermaly, why are the source files contained in a zip file and not directly in the GitHub repoistory, is this because of size?

@llermaly
Copy link
Contributor Author

llermaly commented Jan 5, 2025

@JessicaGarson it is for convenience. Do you want me to change it?

@JessicaGarson
Copy link
Contributor

Thanks, @llermaly. The notebook code looked good, but could you provide more context about why the zip makes it more convenient?

@JessicaGarson
Copy link
Contributor

@llermaly, what exactly does this zip file contain, and how would it be used? I tried downloading it but had issues because it's not fully merged.

@llermaly
Copy link
Contributor Author

@JessicaGarson I just decompressed the zipfile for clarity. Let me know if it works better that way.

@JessicaGarson
Copy link
Contributor

Looks good. I'll go ahead and merge this.

@JessicaGarson JessicaGarson merged commit 05ef7c9 into elastic:main Jan 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessicaGarson JessicaGarson JessicaGarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llermaly @JessicaGarson