Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use published images in chatbot-rag-app example #395

Merged
merged 4 commits into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions example-apps/chatbot-rag-app/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,13 @@ ease while locally is advised if you are making changes to the application.
### Run with docker

Docker compose is the easiest way, as you get one-step to:
* build the [frontend](frontend)
* ingest data into elasticsearch
* run the app, which listens on http://localhost:4000

**Double-check you have a `.env` file with all your variables set first!**

```bash
docker compose up --build --force-recreate
docker compose up --force-recreate
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered --pull always for reproducibility but figured the simpler command is better

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed in principal, but --force-recreate is already there, too. I think we should do --pull-always until the telemetry stuff settles down, so that a future blog won't result in someone retrying and not seeing the new stuff. I know it may be overly cautious, so not hard opinion on this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah given possible telemetry churn makes sense, added it

```

*Note*: First time creating the index can fail on timeout. Wait a few minutes
Expand Down Expand Up @@ -186,6 +185,14 @@ passages. Modify this script to index your own data.

See [Langchain documentation][loader-docs] for more ways to load documents.

### Building from source with docker

To build the app with Docker instead of using published images, pass the `--build`
flag to Compose.

```bash
docker compose up --build --force-recreate
```

---
[loader-docs]: https://python.langchain.com/docs/how_to/#document-loaders
Expand Down
2 changes: 2 additions & 0 deletions example-apps/chatbot-rag-app/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: chatbot-rag-app

services:
ingest-data:
image: ghcr.io/elastic/elasticsearch-labs/chatbot-rag-app
build:
context: .
container_name: ingest-data
Expand All @@ -22,6 +23,7 @@ services:
ingest-data:
condition: service_completed_successfully
container_name: api-frontend
image: ghcr.io/elastic/elasticsearch-labs/chatbot-rag-app
build:
context: .
env_file:
Expand Down