chatbot-rag-app: reduces docker image size #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
smaller-docker
branch
from
069ddd2 to
77cb93e
Compare
codefromthecrypt
changed the title
|
cc @anuraaga |
| @@ -69,7 +69,7 @@ services: | |||
| - XPACK_ENCRYPTEDSAVEDOBJECTS_ENCRYPTIONKEY=fhjskloppd678ehkdfdlliverpoolfcr | |||
| - SERVER_PUBLICBASEURL=http://127.0.0.1:5601 | |||
| healthcheck: | |||
| test: ["CMD-SHELL", "curl -s http://localhost:5601/api/status | grep -q 'All services are available'"] | |||
| test: ["CMD-SHELL", "curl -s http://localhost:5601/api/status | grep -q 'available'"] | |||
There was a problem hiding this comment.
easier match, so keep it simple
| @@ -165,8 +165,6 @@ pip-compile | |||
| pip install -r requirements.txt | |||
| # Add opentelemetry instrumentation for these dependencies | |||
| edot-bootstrap >> requirements.txt | |||
| # Missing dependency for langtrace vertexai instrumentation | |||
There was a problem hiding this comment.
fixed in langtrace 3.3.28
| RUN mkdir ./api | ||
| RUN mkdir ./data | ||
|
|
||
| RUN apt-get update && apt-get install -y \ |
There was a problem hiding this comment.
none of these are required
This was referenced Feb 25, 2025
anuraaga
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the chatbot-rag-app image size from 1.3GB to 820MB by eliminating ancillary packages.
This is more needed when we use k8s which doesn't share an image cache with docker, typically. When demo'ing we want the least download lag possible. Also, my network is not always very strong, so prefer smaller.
While at it, I did a little polishing, too.
Anecdotally, I tried to switch to alpine, but the amount of system packages needed resulted in a larger image than it is now!