Bugfix in Crawler Migration Notebook extraction rule cell #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/410 |
notebooks/enterprise-search/elastic-crawler-to-open-crawler-migration.ipynb
Outdated
Show resolved
Hide resolved
…only receiving the last-known extraction rule and not all extraction rules
|
QA work was completed for this PR here --> https://github.com/elastic/search-team/issues/9366 |
JessicaGarson
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/search-team/issues/9376
This PR fixes a bug was found in the Elastic Crawler notebook where the extraction rule cell was attempting to add extraction rules for domains that technically no longer exist. This is due to how certain actastic indices work (the extraction rules index doesn't seem to be kept in sync with the domains index)
This PR also fixes a related bug where a Crawler with multiple extraction rules was only receiving the last-known extraction rule instead of all extraction rules