Add last refresh times and unwritten changes state to RefreshStats #111220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v8.16.0
needs:triage
limotova
commented
Jul 24, 2024
| /** | ||
| * Timestamp of the last refresh. | ||
| */ | ||
| public long getLastRefreshTime() { |
There was a problem hiding this comment.
I decided to make these values timestamps rather than a duration (like timeSinceLastRefresh) because from what I could tell timestamps are more widely used in the stats, but also because it was proving it be very difficult to write solid tests when the stat grows with time.
limotova
commented
Jul 24, 2024
| /** | ||
| * Whether there are changes that need to be written to disk or not. | ||
| */ | ||
| public boolean getHasUnwrittenChanges() { |
There was a problem hiding this comment.
I went back and forth between unwritten and unrefreshed and settled on unwritten, but I'm happy to change it to unrefreshed..!
saikatsarkar056
added
the
:Distributed Indexing/Engine
elasticsearchmachine
added
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
v9.1.0
Team:Distributed Indexing
|
Pinging @elastic/es-distributed-obsolete (Team:Distributed (Obsolete)) |
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds several fields to RefreshStats, including the last external and
internal refresh times, and a flag indicating if the shard has unwritten
changes.
Fixes #110852