Speedup reading TranslogHeader #112073
Open
Speedup reading TranslogHeader #112073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See elastic#112072 which also fixes the issue by speeding up `read` itself. We should just use `readBytes` here to begin with though to ensure we read enough bytes for the UUID directly.
original-brownbear
added
>non-issue
:Distributed Indexing/Engine
elasticsearchmachine
added
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
v9.1.0
Team:Distributed Indexing
|
Pinging @elastic/es-distributed-obsolete (Team:Distributed (Obsolete)) |
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #112072 which also fixes the issue by speeding up
readitself. We should just usereadByteshere to begin with though to ensure we read enough bytes for the UUID directly.Practically this isn't super bad since we only read so many translog headers, but it's a visible speedup to internal cluster tests at the very least.