Fix live version map unsafe flag #116053
Draft
Fix live version map unsafe flag #116053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Live version map can unexpectedly go unsafe with single threaded indexing going on. This can cause translog replay to need to transition from unsafe to safe version map.
henningandersen
added
>bug
:Distributed Indexing/Engine
|
Hi @henningandersen, I've created a changelog YAML for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live version map can unexpectedly go unsafe with single threaded indexing going on. This can cause translog replay to need to transition from unsafe to safe version map.
This draft pull request illustrates the problem through a test-case and a hacky fix to the live version map.