Wait for global checkpoint update before retrieving shard changes #119128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvatore-campagna
changed the title
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
I evaluated the option to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a race condition in a test that interacts with the shardChanges API. The test now explicitly waits for the global checkpoint to be updated to a non-negative value before proceeding. This prevents potential timeouts that could occur when the requested
seq_no(0) is greater than the initial global checkpoint value. The fix utilizes the shard stats API to monitor the global checkpoint and ensures that the shardChanges API call is made only when the checkpoint is at least 0.Resolves #118800