Skip to content

Remove IndexSettingDeprecatedInV7AndRemovedInV8 removal TODOs #119842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove IndexSettingDeprecatedInV7AndRemovedInV8 removal TODOs #119842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e651a01
Remove IndexSettingDeprecatedInV7AndRemovedInV8 removal TODOs
cbuescher Jan 9, 2025
ee8fd9a
Merge branch 'main' into IndexSettingDeprecatedInV7AndRemovedInV8-v9-…
cbuescher Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions server/src/main/java/org/elasticsearch/cluster/metadata/IndexMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,8 +510,7 @@ public Iterator<Setting<?>> settings() {
);

/**
* Legacy index setting, kept for 7.x BWC compatibility. This setting has no effect in 8.x. Do not use.
* TODO: Remove in 9.0
* Legacy index setting, kept for 7.x read-only BWC compatibility. This setting has no effect in 8.x. Do not use.
*/
@Deprecated
public static final Setting<String> INDEX_ROLLUP_SOURCE_UUID = Setting.simpleString(
Expand All @@ -522,8 +521,7 @@ public Iterator<Setting<?>> settings() {
);

/**
* Legacy index setting, kept for 7.x BWC compatibility. This setting has no effect in 8.x. Do not use.
* TODO: Remove in 9.0
* Legacy index setting, kept for 7.x read-only BWC compatibility. This setting has no effect in 8.x. Do not use.
*/
@Deprecated
public static final Setting<String> INDEX_ROLLUP_SOURCE_NAME = Setting.simpleString(
Expand Down
3 changes: 1 addition & 2 deletions server/src/main/java/org/elasticsearch/index/IndexSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,8 +765,7 @@ public Iterator<Setting<?>> settings() {
);

/**
* Legacy index setting, kept for 7.x BWC compatibility. This setting has no effect in 8.x. Do not use.
* TODO: Remove in 9.0
* Legacy index setting, kept for 7.x read-only BWC compatibility. This setting has no effect in 8.x. Do not use.
*/
@Deprecated
public static final Setting<Integer> MAX_ADJACENCY_MATRIX_FILTERS_SETTING = Setting.intSetting(
Expand Down
3 changes: 1 addition & 2 deletions server/src/main/java/org/elasticsearch/index/IndexingSlowLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ public final class IndexingSlowLog implements IndexingOperationListener {
);

/**
* Legacy index setting, kept for 7.x BWC compatibility. This setting has no effect in 8.x. Do not use.
* TODO: Remove in 9.0
* Legacy index setting, kept for 7.x read-only BWC compatibility. This setting has no effect in 8.x. Do not use.
*/
@Deprecated
public static final Setting<SlowLogLevel> INDEX_INDEXING_SLOWLOG_LEVEL_SETTING = new Setting<>(
Expand Down
3 changes: 1 addition & 2 deletions server/src/main/java/org/elasticsearch/index/SearchSlowLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,7 @@ public final class SearchSlowLog implements SearchOperationListener {
);

/**
* Legacy index setting, kept for 7.x BWC compatibility. This setting has no effect in 8.x. Do not use.
* TODO: Remove in 9.0
* Legacy index setting, kept for 7.x read-only BWC compatibility. This setting has no effect in 8.x. Do not use.
*/
@Deprecated
public static final Setting<SlowLogLevel> INDEX_SEARCH_SLOWLOG_LEVEL = new Setting<>(
Expand Down
3 changes: 1 addition & 2 deletions server/src/main/java/org/elasticsearch/index/engine/EngineConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,7 @@ public Supplier<RetentionLeases> retentionLeasesSupplier() {
public static final String USE_COMPOUND_FILE = "index.use_compound_file";

/**
* Legacy index setting, kept for 7.x BWC compatibility. This setting has no effect in 8.x. Do not use.
* TODO: Remove in 9.0
* Legacy index setting, kept for 7.x read-only BWC compatibility. This setting has no effect in 8.x. Do not use.
*/
@Deprecated
public static final Setting<Boolean> INDEX_OPTIMIZE_AUTO_GENERATED_IDS = Setting.boolSetting(
Expand Down
3 changes: 1 addition & 2 deletions server/src/main/java/org/elasticsearch/index/store/Store.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,7 @@
public class Store extends AbstractIndexShardComponent implements Closeable, RefCounted {

/**
* Legacy index setting, kept for 7.x BWC compatibility. This setting has no effect in 8.x. Do not use.
* TODO: Remove in 9.0
* Legacy index setting, kept for 7.x read-only BWC compatibility. This setting has no effect in 8.x. Do not use.
*/
@Deprecated
public static final Setting<Boolean> FORCE_RAM_TERM_DICT = Setting.boolSetting(
Expand Down