Update 101 and 912 CompletionPostingFormats to use off-heap FST load mode #123011
+52
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heap Identical to that of Lucene's Completion101PostingsFormat, except that we flip the default to FSTLoadMode.OFF_HEAP
|
In all of my local testing these ES formats are always found first.
|
elasticsearchmachine
added
v9.1.0
needs:triage
ChrisHegarty
changed the title
ChrisHegarty
added
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
|
Hi @ChrisHegarty, I've created a changelog YAML for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical to that of Lucene's Completion101PostingsFormat, except that we flip the default to FSTLoadMode.OFF_HEAP.
These implementations reuse the exact same format name as that of the formats provided by the
org.apache.lucene.suggestmodule. In effect they "override" the formats provided by that module, since Lucene's NamedSPILoader only uses the first service for each name found, later services will be ignored. So once we find the ES versions first, then they will be used rather than the Lucene ones.