-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[ES|QL] Date nanos implicit casting in union types #123678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
fang-xing-esql
wants to merge
34
commits into
elastic:main
from
fang-xing-esql:date-nanos-implicit-casting
Closed
Changes from 26 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
42ce293
implicit casting for date nanos
fang-xing-esql e006e07
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql 5436afb
implicit casting for union typed field in logical plan
fang-xing-esql 08d395c
Update docs/changelog/123678.yaml
fang-xing-esql 93615fb
Merge branch 'main' into date-nanos-implicit-casting
elasticmachine 3552ae3
more implicit casting for union typed field in logical plan
fang-xing-esql 811c5a3
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql 3fb26ed
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql b49a48d
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql 29f7afe
refactor
fang-xing-esql ed8ce9b
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql c13e83c
support aggregations with bucket and more tests
fang-xing-esql e26d25d
correct typo
fang-xing-esql 3b36978
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql 02e2260
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql 29b1155
remove grok and dissect, add enrich
fang-xing-esql e0b903d
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql d0d46f6
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql 654e6ce
more tests around date functions
fang-xing-esql 612810e
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql 700ef2a
Merge remote-tracking branch 'origin/main' into date-nanos-implicit-c…
craigtaverner 2c5da6e
DateNanos should now require a minimum of three decimal places
craigtaverner 76f19f3
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql 279d368
refactor and remove implicit casting for numeric types
fang-xing-esql 4fb446b
update tests
fang-xing-esql 00b6229
fix tests
fang-xing-esql 2d68f85
push down binary comparisons on date and date nanos union type fields
fang-xing-esql 39acff6
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql 8c04bcc
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql 4284c16
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql 56dd224
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql 46e3c95
modify testSuggestedCast as date_nanos and date are casted to date_na…
fang-xing-esql 7256326
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql deb3c41
Merge branch 'main' into date-nanos-implicit-casting
fang-xing-esql File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
pr: 123678 | ||
summary: Date nanos implicit casting | ||
area: ES|QL | ||
type: enhancement | ||
issues: | ||
- 110009 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
x-pack/plugin/esql/qa/testFixtures/src/main/resources/data/date_nanos_union_types.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
millis:date_nanos,nanos:date,num:long | ||
2023-10-23T13:55:01.543123456Z,2023-10-23T13:55:01.543Z,1698069301543123456 | ||
2023-10-23T13:55:01.543123456Z,2023-10-23T13:55:01.543Z,1698069301543123456 | ||
2023-10-23T13:53:55.832987654Z,2023-10-23T13:53:55.832Z,1698069235832987654 | ||
2023-10-23T13:52:55.015787878Z,2023-10-23T13:52:55.015Z,1698069175015787878 | ||
2023-10-23T13:51:54.732102837Z,2023-10-23T13:51:54.732Z,1698069114732102837 | ||
2023-10-23T13:33:34.937193000Z,2023-10-23T13:33:34.937Z,1698068014937193000 | ||
2023-10-23T12:27:28.948000000Z,2023-10-23T12:27:28.948Z,1698064048948000000 | ||
2023-10-23T12:15:03.360103847Z,2023-10-23T12:15:03.360Z,1698063303360103847 | ||
2023-10-23T12:15:03.360103847Z,2023-10-23T12:15:03.360Z,1698063303360103847 | ||
1999-10-23T12:15:03.360103847Z,[2023-03-23T12:15:03.360Z, 2023-02-23T13:33:34.937Z, 2023-01-23T13:55:01.543Z], 0 | ||
1999-10-22T12:15:03.360103847Z,[2023-03-23T12:15:03.360Z, 2023-03-23T12:15:03.360Z, 2023-03-23T12:15:03.360Z], 0 | ||
2023-10-23T12:15:03.360103847Z,1923-10-23T12:15:03.360Z,1698063303360103847 |
2 changes: 1 addition & 1 deletion
2
x-pack/plugin/esql/qa/testFixtures/src/main/resources/data/employees_incompatible.csv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
x-pack/plugin/esql/qa/testFixtures/src/main/resources/mapping-date_nanos_union_types.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
"properties": { | ||
"millis": { | ||
"type": "date_nanos" | ||
}, | ||
"nanos": { | ||
"type": "date" | ||
}, | ||
"num": { | ||
"type": "long" | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.