Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update missed documentation change for new watcher index settings #125758

Open
wants to merge 1 commit into
base: 8.x
Choose a base branch
from

Conversation

lukewhiting
Copy link
Contributor

This PR adds a documentation change to the 8.x branches that was missed when merging #115251.

9.x documentation is handled in the new elasticsearch-spec docs system via elastic/elasticsearch-specification#4141

@lukewhiting lukewhiting added >docs General docs changes :Data Management/Watcher auto-backport Automatically create backport pull requests when merged v8.18.0 v8.19.0 v8.17.5 labels Mar 27, 2025
@lukewhiting lukewhiting requested a review from masseyke March 27, 2025 10:26
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Mar 27, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@PeteGillinElastic PeteGillinElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and looks like it matches the implementation so LGTM.

@@ -11,10 +11,17 @@
For the most up-to-date API details, refer to {api-es}/group/endpoint-watcher[{watcher} APIs].
--

This API allows a user to modify the settings for the Watcher internal index (`.watches`). Only a subset of settings are allowed to by modified. This includes:
This API allows a user to modify the settings for the Watcher internal index (`.watches`). Only a subset of settings
are allowed to by modified. This includes:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
are allowed to by modified. This includes:
are allowed to be modified. This includes:

Copy link
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the typo, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Data Management/Watcher >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v8.17.5 v8.18.0 v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants