Skip to content

Add per-project service account auth #126612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jfreden
Copy link
Contributor

@jfreden jfreden commented Apr 10, 2025

  • ServiceAccountToken constructor was changed to public, because the token had to be in core due to it being part of the interface in security extension, that's part of core. A lot of tests already rely on the constructor being package private. An aleternatie would be to move the ServiceAccountService to core, but that involves moving all service account definitions to core, which feels like too big of a refactor to justify. Ideally the tests should not use an interface that's not public and instead use a mock.
  • Add tests
  • Should we validate that no cluster level service account file is configured?
  • Should we validate that no index level service account is configured?
  • Token source, should we add some tests for it?
  • Revert change to some of the token things

@elasticsearchmachine elasticsearchmachine added serverless-linked Added by automation, don't add manually v9.1.0 labels Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
serverless-linked Added by automation, don't add manually v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants