-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Adding support to exclude semantic_text subfields #127664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 3 commits
1a3bb97
522730e
db64ad2
e333e78
06caf66
5572275
785e8d6
9e65cd0
56fb75c
232879b
f2e5dae
f75d236
eb9b56b
1e53918
811adcf
25f8bca
b549efc
1b25b4a
969e9bf
7da5bd6
a64c65f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
pr: 127664 | ||
summary: Exclude `semantic_text` subfields from field capabilities API | ||
area: "Mapping" | ||
type: enhancement | ||
issues: [] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -148,6 +148,26 @@ setup: | |
- not_exists: fields.dense_field | ||
- match: { fields.sparse_field.text.searchable: true } | ||
|
||
--- | ||
"Field caps exclude chunks and embedding fields": | ||
- requires: | ||
cluster_features: "gte_v8.16.0" | ||
reason: field_caps support for semantic_text added in 8.16.0 | ||
Samiul-TheSoccerFan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- do: | ||
field_caps: | ||
include_empty_fields: true | ||
index: test-index | ||
fields: "*" | ||
|
||
- match: { indices: [ "test-index" ] } | ||
- exists: fields.sparse_field | ||
- exists: fields.dense_field | ||
- not_exists: fields.sparse_field.chunks.embeddings | ||
- not_exists: fields.sparse_field.chunks.embeddings.offsets | ||
- not_exists: fields.dense_field.chunks.embeddings | ||
- not_exists: fields.dense_field.chunks.embeddings.offsets | ||
|
||
--- | ||
"Indexes dense vector document": | ||
# Checks mapping is not updated until first doc arrives | ||
|
@@ -359,3 +379,23 @@ setup: | |
index: test-always-include-inference-id-index | ||
|
||
- exists: test-always-include-inference-id-index.mappings.properties.semantic_field.inference_id | ||
|
||
--- | ||
"Field caps exclude chunks and embedding fields": | ||
- requires: | ||
cluster_features: "gte_v8.16.0" | ||
reason: field_caps support for semantic_text added in 8.16.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need to define a new cluster feature? As per my understanding, these fields are not expected from There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it would be good to create a test feature for these tests. |
||
|
||
- do: | ||
field_caps: | ||
include_empty_fields: true | ||
index: test-index | ||
fields: "*" | ||
|
||
- match: { indices: [ "test-index" ] } | ||
- exists: fields.sparse_field | ||
- exists: fields.dense_field | ||
- not_exists: fields.sparse_field.chunks.embeddings | ||
- not_exists: fields.sparse_field.chunks.offset | ||
- not_exists: fields.dense_field.chunks.embeddings | ||
- not_exists: fields.dense_field.chunks.offset | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this be Also, can we check that field caps excludes |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -307,3 +307,22 @@ setup: | |
another_field: | ||
type: keyword | ||
|
||
--- | ||
"Field caps exclude chunks embedding and text fields": | ||
- requires: | ||
cluster_features: "gte_v8.16.0" | ||
reason: field_caps support for semantic_text added in 8.16.0 | ||
|
||
- do: | ||
field_caps: | ||
include_empty_fields: true | ||
index: test-index | ||
fields: "*" | ||
|
||
- match: { indices: [ "test-index" ] } | ||
- exists: fields.sparse_field | ||
- exists: fields.dense_field | ||
- not_exists: fields.sparse_field.inference.chunks.embeddings | ||
- not_exists: fields.sparse_field.inference.chunks.text | ||
- not_exists: fields.dense_field.inference.chunks.embeddings | ||
- not_exists: fields.dense_field.inference.chunks.text | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we check that field caps excludes |
Uh oh!
There was an error while loading. Please reload this page.