[Entitlements] Add test entitlement bootstrap and initialization classes #127814
+225
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
ldematte
added
WIP
:Core/Infra/Entitlements
prdoyle
reviewed
May 7, 2025
...ment/src/main/java/org/elasticsearch/entitlement/initialization/EntitlementCheckerUtils.java
Outdated
Show resolved
Hide resolved
| pluginPolicies, | ||
| null, // TestScopeResolver.createScopeResolver | ||
| Map.of(), // TODO: a map that always return nulls? Replace with functor | ||
| ENTITLEMENTS_MODULE, // TODO: this will need to change -- encapsulate it when we extract isTriviallyAllowed |
There was a problem hiding this comment.
Oh interesting. What do you have in mind here?
There was a problem hiding this comment.
If you go with Ryan's suggestion to replace the methods altogether, this will be part of the prod code -- the test code could just test for package name like junit or gradle. I'll wait and see how that evolves :)
ldematte
added a commit
that referenced
this pull request
May 8, 2025
Preliminary step for test entitlement initialization, extracted from #127814
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
May 8, 2025
Preliminary step for test entitlement initialization, extracted from elastic#127814
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
May 8, 2025
Preliminary step for test entitlement initialization, extracted from elastic#127814
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
May 8, 2025
Preliminary step for test entitlement initialization, extracted from elastic#127814
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 8, 2025
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
May 9, 2025
Preliminary step for test entitlement initialization, extracted from elastic#127814
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
Preliminary step for test entitlement initialization, extracted from elastic#127814
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: we still lack some preliminary "ingredients":
See TODOs in
TestEntitlementInitialization