ESQL: Round in stats test for docs #128048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Serverless tests, we sometimes hit rounding errors because even single node tests are executed on 3 nodes there. Rounding makes this test deterministic.
alex-spies
added
>test
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
bpintea
approved these changes
May 13, 2025
richard-dennehy
pushed a commit
to richard-dennehy/elasticsearch
that referenced
this pull request
May 19, 2025
In Serverless tests, we sometimes hit rounding errors because even single node tests are executed on 3 nodes there. Rounding makes this test deterministic.
benchaplin
pushed a commit
to benchaplin/elasticsearch
that referenced
this pull request
May 20, 2025
In Serverless tests, we sometimes hit rounding errors because even single node tests are executed on 3 nodes there. Rounding makes this test deterministic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Serverless tests, we sometimes hit rounding errors because even single node tests are executed on 3 nodes there. Rounding makes this test deterministic.