Skip to content

Note in Javadocs that SubscribableListener fires once #128131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DaveCTurner
Copy link
Contributor

Spell out that multiple completions of a SubscribableListener race to
be chosen as the winner that is passed to subscribed listeners, such
that the subscribed listeners all fire at most once.

Spell out that multiple completions of a `SubscribableListener` race to
be chosen as the winner that is passed to subscribed listeners, such
that the subscribed listeners all fire at most once.
@DaveCTurner DaveCTurner requested a review from alex-spies May 19, 2025 12:22
@DaveCTurner DaveCTurner added >docs General docs changes v8.19.0 v9.1.0 :Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. labels May 19, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Distributed Coordination Meta label for Distributed Coordination team labels May 19, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@DaveCTurner DaveCTurner requested a review from ywangd May 27, 2025 13:27
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged labels May 27, 2025
@elasticsearchmachine elasticsearchmachine merged commit cdc7474 into elastic:main May 27, 2025
17 checks passed
@DaveCTurner DaveCTurner deleted the 2025/05/19/SubscribableListener-fires-once branch May 27, 2025 14:33
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request May 27, 2025
Spell out that multiple completions of a `SubscribableListener` race to
be chosen as the winner that is passed to subscribed listeners, such
that the subscribed listeners all fire at most once.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.19

elasticsearchmachine pushed a commit that referenced this pull request May 27, 2025
…28515)

Spell out that multiple completions of a `SubscribableListener` race to
be chosen as the winner that is passed to subscribed listeners, such
that the subscribed listeners all fire at most once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. >docs General docs changes Team:Distributed Coordination Meta label for Distributed Coordination team Team:Docs Meta label for docs team v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants