-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Note in Javadocs that SubscribableListener
fires once
#128131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elasticsearchmachine
merged 2 commits into
elastic:main
from
DaveCTurner:2025/05/19/SubscribableListener-fires-once
May 27, 2025
Merged
Note in Javadocs that SubscribableListener
fires once
#128131
elasticsearchmachine
merged 2 commits into
elastic:main
from
DaveCTurner:2025/05/19/SubscribableListener-fires-once
May 27, 2025
+9
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spell out that multiple completions of a `SubscribableListener` race to be chosen as the winner that is passed to subscribed listeners, such that the subscribed listeners all fire at most once.
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
ywangd
approved these changes
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 27, 2025
Spell out that multiple completions of a `SubscribableListener` race to be chosen as the winner that is passed to subscribed listeners, such that the subscribed listeners all fire at most once.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 27, 2025
…28515) Spell out that multiple completions of a `SubscribableListener` race to be chosen as the winner that is passed to subscribed listeners, such that the subscribed listeners all fire at most once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Distributed Coordination/Distributed
A catch all label for anything in the Distributed Coordination area. Please avoid if you can.
>docs
General docs changes
Team:Distributed Coordination
Meta label for Distributed Coordination team
Team:Docs
Meta label for docs team
v8.19.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spell out that multiple completions of a
SubscribableListener
race tobe chosen as the winner that is passed to subscribed listeners, such
that the subscribed listeners all fire at most once.