-
Notifications
You must be signed in to change notification settings - Fork 25.2k
ES|QL: Test FORK with multi cluster #128310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ioanatia
wants to merge
2
commits into
elastic:main
Choose a base branch
from
ioanatia:fork_ccs_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
12 tasks
dnhatn
approved these changes
May 22, 2025
got another failure after merging main - cannot replicate locally 😞 seems to be the same type of issue as before with results not coming back:
putting this back in draft until I figure it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
>non-issue
:Search Relevance/Search
Catch all for Search Relevance
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #121950
We initially skipped CCS tests (PR) after we merged streaming support for FORK because the tests were flaky.
My assumption is that the fix from #127328 when we correctly wrapped all the sub plan executions in the same
ComputeListener
should also fix the failures we had seen with CCS when using FORK.The failures we have seen with CCS had to do with the request returning incomplete results, where we did not include the results from some of the FORK branches. This seems to indicate we did not properly wait for all results to be returned, which should now be hopefully fixed with #127328.