Skip to content

ES|QL: Test FORK with multi cluster #128310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ioanatia
Copy link
Contributor

@ioanatia ioanatia commented May 22, 2025

related #121950

We initially skipped CCS tests (PR) after we merged streaming support for FORK because the tests were flaky.

My assumption is that the fix from #127328 when we correctly wrapped all the sub plan executions in the same ComputeListener should also fix the failures we had seen with CCS when using FORK.
The failures we have seen with CCS had to do with the request returning incomplete results, where we did not include the results from some of the FORK branches. This seems to indicate we did not properly wait for all results to be returned, which should now be hopefully fixed with #127328.

@ioanatia ioanatia added :Analytics/ES|QL AKA ESQL :Search Relevance/Search Catch all for Search Relevance >non-issue labels May 22, 2025
@ioanatia ioanatia changed the title ESTest FORK with multi cluster ES|QL: Test FORK with multi cluster May 22, 2025
@ioanatia ioanatia marked this pull request as ready for review May 22, 2025 14:58
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels May 22, 2025
@ioanatia ioanatia requested a review from tteofili May 22, 2025 14:58
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@ioanatia ioanatia mentioned this pull request May 21, 2025
12 tasks
@ioanatia
Copy link
Contributor Author

got another failure after merging main - cannot replicate locally 😞

seems to be the same type of issue as before with results not coming back:

java.lang.AssertionError: Expected more data but no more entries found after [3] |  
-- | --
  | Data mismatch: |  
  |   |  
  | Actual: |  
  | _fork:keyword \| emp_no:integer \| x:keyword \| y:keyword \| z:keyword \| a:keyword |  
  | fork1         \| 10048          \| Florian   \| 10048     \| Syrotiuk  \| Florian 10048 Syrotiuk |  
  | fork1         \| 10081          \| Zhongwei  \| 10081     \| Rosen     \| Zhongwei 10081 Rosen |  
  | fork2         \| null           \| 2         \| 10081     \| 10048     \| null |  
  |   |  
  | Expected: |  
  | _fork:keyword \| emp_no:integer \| x:keyword \| y:keyword \| z:keyword \| a:keyword |  
  | fork1         \| 10048          \| Florian   \| 10048     \| Syrotiuk  \| Florian 10048 Syrotiuk |  
  | fork1         \| 10081          \| Zhongwei  \| 10081     \| Rosen     \| Zhongwei 10081 Rosen |  
  | fork2         \| null           \| 2         \| 10081     \| 10048     \| null |  
  | fork3         \| 10048          \| Syrotiuk  \| null      \| null      \| null |  
  | fork3         \| 10081          \| Rosen     \| null      \| null      \| null |  
  | fork4         \| 10048          \| abc       \| aaa       \| null      \| null |  
  | fork4         \| 10081          \| abc       \| aaa       \| null      \| null |  
  |  

putting this back in draft until I figure it out

@ioanatia ioanatia marked this pull request as draft May 22, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >non-issue :Search Relevance/Search Catch all for Search Relevance Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants