Block loaders for MV_MIN and MV_MAX for keywords #137473
Open
+1,396
−448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds special purpose `BlockLoader` implementations for the `MV_MIN` and `MV_MAX` functions for `keyword` fields with doc values. These are a noop for single valued keywords but should be *much* faster for multivalued keywords. These aren't plugged in yet. We can plug them in and performance test them in elastic#137382. And they give us two more functions we can use to demonstrate elastic#137382.
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
dnhatn
approved these changes
Nov 3, 2025
| if (docs.count() - offset == 1) { | ||
| return readSingleDoc(factory, docs.get(offset)); | ||
| } | ||
| try (var builder = factory.sortedSetOrdinalsBuilder(ordinals, docs.count() - offset)) { |
There was a problem hiding this comment.
We should use singletonOrdinalsBuilder since each row should have at most one value. However, we are not using it because it requires SortedDocValues. This is not an issue here, but if this pattern recurs, we might consider relaxing singletonOrdinalsBuilder to accept an interface that supports looking up terms by ordinal.
|
|
||
| @Override | ||
| protected AllReader sortedSetReader(SortedSetDocValues docValues) { | ||
| return new MvMaxSortedSet(docValues); |
There was a problem hiding this comment.
I considered wrapping SortedSetDocValues as SortedDocValues and then calling Singleton, but I think the approach in this PR is safer.
There was a problem hiding this comment.
It's just a little more paranoid, yeah.
| /** | ||
| * Loads {@code keyword} style fields that are stored as a lookup table. | ||
| */ | ||
| abstract class AbstractBytesRefsFromOrdsBlockLoader extends BlockDocValuesReader.DocValuesBlockLoader { |
|
|
||
| @Override | ||
| protected AllReader sortedReader(SortedNumericDocValues docValues) { | ||
| return new MvMinSorted(docValues); |
| return "IntsFromDocValues[" + fieldName + "]"; | ||
| } | ||
|
|
||
| public static class MvMinSorted extends BlockDocValuesReader { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds special purpose
BlockLoaderimplementations for theMV_MINandMV_MAXfunctions forkeywordfields with doc values. These are a noop for single valued keywords but should be much faster for multivalued keywords.These aren't plugged in yet. We can plug them in and performance test them in #137382. And they give us two more functions we can use to demonstrate #137382.