Fix illegal_access_exception: class com.maxmind.db.Decoder from ip_location processor #137479
+109
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because I added another database to the fixtures, the old (unchanged) tests don't work with this new code anymore. We might be able to get out of this situation long term by rewriting the tests or backporting some of these changes, but for now I think it's most expedient to 'just' disable them.
joegallo
added
>bug
:Data Management/Ingest Node
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @joegallo, I've created a changelog YAML for you. |
joegallo
added
the
auto-backport
💚 Backport successful
|
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you attempt to use the
ip_locationprocessor onv9.2.0of Elasticsearch, you'll get an illegal access exception like this one:The issue is that our
IpinfoIpDataLookupsis not being correctly exposed to theMaxMind-DB-Reader-javalibrary that Elasticsearch uses for interacting with MMDB files (i.e. it's a modules/permissions issue).#132595, which shipped in 9.2.0 accidentally broke IPinfo database access because it removed the module access that allows things to work. This PR adds the module access back, so the fix is the dozen-ish characters added in
module-info.java.The rest of the PR is overhead to first make there be a failing test that shows that there's even a problem (and which then passes once the problem has been fixed). That is, while #132595 introduced the breakage, the real issue is that this module dependency wasn't correctly exercised by our tests, and this PR fixes that more important issue.
edit: Of course there are plenty of other tests for this code, just none that explicitly relied on the module behavior in the right way the same as it works at runtime as it turns out.