Adjust sampling max size limit to depend on heap size #137482
+93
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the max size limit on sampling configurations to be dynamically calculated as 1% of a node's heap size instead of using a fixed 5GB limit, with a minimum floor of 100KB to ensure reasonable defaults for small heap environments.
- Replaces static
MAX_SIZE_LIMIT_GIGABYTESconstant with heap-based percentage calculation - Introduces
DEFAULT_MAX_SIZE_FLOORconstant for minimum size guarantee - Updates validation logic and test data generation to use dynamic heap-based limits
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| SamplingConfiguration.java | Core implementation of heap-based size calculation and validation logic |
| SamplingConfigurationTests.java | Updated test generation and validation to use dynamic heap limits |
| TransportPutSampleConfigurationActionTests.java | Modified random test data generation to use fixed MB values |
| TransportDeleteSampleConfigurationActionTests.java | Modified random test data generation to use fixed MB values |
| GetAllSampleConfigurationActionIT.java | Modified random test data generation to use fixed MB values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
server/src/main/java/org/elasticsearch/action/admin/indices/sampling/SamplingConfiguration.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/elasticsearch/action/admin/indices/sampling/SamplingConfigurationTests.java
Show resolved
Hide resolved
...rc/test/java/org/elasticsearch/action/admin/indices/sampling/SamplingConfigurationTests.java
Show resolved
Hide resolved
…mpling/SamplingConfiguration.java Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
elasticsearchmachine
added
the
needs:triage
seanzatzdev
added
>non-issue
:Data Management/Ingest Node
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the max size limit on sampling configurations to be a function (1%) of a node's heap size. there is also a minimum default max size of 100kb.