Add batching to TransportClusterUpdateSettingsAction #97246
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworks `TransportClusterUpdateSettingsAction` to use a batching executor, mainly to avoid the need to hold mutable state within the task itself. Also moves the submission of the followup reroute task into the publication-complete handler, since this submission step need not wait for acking.
DaveCTurner
added
WIP
:Distributed Indexing/Distributed
|
NB no tests here yet, this is really more of a placeholder for this tech debt task. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks
TransportClusterUpdateSettingsActionto use a batchingexecutor, mainly to avoid the need to hold mutable state within the task
itself. Also moves the submission of the followup reroute task into the
publication-complete handler, since this submission step need not wait
for acking.