Skip to content

fix: attach orphan comments to root AST node when query has no commands#51

Merged
bartoval merged 2 commits into
elastic:mainfrom
bartoval:fix_comment_without_parent_node
Mar 10, 2026
Merged

fix: attach orphan comments to root AST node when query has no commands#51
bartoval merged 2 commits into
elastic:mainfrom
bartoval:fix_comment_without_parent_node

Conversation

@bartoval
Copy link
Copy Markdown
Contributor

@bartoval bartoval commented Mar 9, 2026

Summary

This fix prevents showing suggestions when editor starts with a comment
image

comments.mp4

@bartoval
Copy link
Copy Markdown
Contributor Author

bartoval commented Mar 9, 2026

I'm not sure if inline suggestions should be handled as well. But that's probably a Kibana-side issue.

@bartoval bartoval self-assigned this Mar 9, 2026
@bartoval bartoval marked this pull request as ready for review March 9, 2026 16:04
@bartoval bartoval requested a review from a team as a code owner March 9, 2026 16:04
@stratoula
Copy link
Copy Markdown
Contributor

stratoula commented Mar 9, 2026

@bartoval can we do something for this No suggestions popup that appears?

Also how it works when there is already a query below and you just want to add a comment at the top?

@bartoval
Copy link
Copy Markdown
Contributor Author

bartoval commented Mar 9, 2026

@bartoval can we do something for this No suggestions popup that appears?

@bartoval can we do something for this No suggestions popup that appears?

Also how it works when there is already a query below and you just want to add a comment at the top?

that?

tt.mp4

I can't resolve the popup here. I have to do it in Kibana.

@stratoula
Copy link
Copy Markdown
Contributor

@bartoval can we do something for this No suggestions popup that appears?

@bartoval can we do something for this No suggestions popup that appears?
Also how it works when there is already a query below and you just want to add a comment at the top?

that?

tt.mp4
I can't resolve the popup here. I have to do it in Kibana.

yes I figured, ok let's also remove this stupid No suggestions popover at the kibana side

@bartoval bartoval merged commit fe61103 into elastic:main Mar 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants