feat: Update grammars#65
Merged
Merged
Conversation
elastic-vault-github-plugin-prod
Bot
requested a review
from a team
as a code owner
Contributor
|
bang |
bartoval
reviewed
Mar 19, 2026
| const byCtx = ctx.BY(); | ||
| const args = this.fromFields(expr); | ||
|
|
||
| if (!byCtx || !expr) { |
Contributor
There was a problem hiding this comment.
Stats is identical. We just moved the logic to the parent to pass args instead of expr and reuse the function also with Limit by
stratoula
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the ES|QL grammars (lexer and parser) and PromQL grammars to match the latest version in Elasticsearch.