[Docs] Wrap EuiButtonIcon with tooltips#9771
Open
weronikaolejniczak wants to merge 3 commits into
Open
Conversation
1 visual difference(s) found - expand to review, then click Approve visual changes to update baselineseuipopover (1 difference)
|
weronikaolejniczak
added
the
skip-vrt
weronikaolejniczak
force-pushed
the
fix/docs
branch
from
cd058c3 to
bcc56be
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the EUI button documentation to align EuiButtonIcon examples with the repo’s tooltip guidance and the @elastic/eui/tooltip-button-icon-wrap ESLint rule, by documenting and demonstrating tooltip wrapping for icon-only buttons.
Changes:
- Adds written guidance (and examples) recommending
EuiToolTipwrapping forEuiButtonIconinstead of using the nativetitleprop. - Updates multiple interactive doc examples to wrap
EuiButtonIconinstances inEuiToolTip. - Removes
titleusage from toggle button icon examples in favor ofEuiToolTip.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
💚 Build Succeeded
|
weronikaolejniczak
force-pushed
the
fix/docs
branch
from
346f267 to
fe04dcc
Compare
weronikaolejniczak
force-pushed
the
fix/docs
branch
from
fe04dcc to
de41976
Compare
💚 Build Succeeded
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@JasonStoltz raised a point about our button docs contradicting our guidelines:
EuiButtonIconwere not wrapped withEuiToolTip. So this simply addresses that.Screenshots
QA instructions for reviewer
Ensure that:
EuiButtonIconare wrapped with a tooltipSite-wide (
docusaurus-theme- check on any page)disableScreenReaderOutput)Specific pages