-
Notifications
You must be signed in to change notification settings - Fork 93
[8.17](backport #4784) fix: add grpcnotrace to go build tags #4824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 8.17
Are you sure you want to change the base?
Conversation
* fix: add grpcnotrace to go build tags resolve blockers to enable DCE (deadcode elimination) Pass grpcnotrace tag to remove x/net/trace dependency in grpc dependency causing DCE to be disabled fleet-server binary size (make local): 35M -> 23M * changelog: add fragment (cherry picked from commit 6c35557) # Conflicts: # Makefile
Cherry-pick of 6c35557 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This pull request has not been merged yet. Could you please review and merge it @kruskall? 🙏 |
The PRs that added |
This pull request has not been merged yet. Could you please review and merge it @kruskall? 🙏 |
2 similar comments
This pull request has not been merged yet. Could you please review and merge it @kruskall? 🙏 |
This pull request has not been merged yet. Could you please review and merge it @kruskall? 🙏 |
What is the problem this PR solves?
DCE is disabled in fleet-server
How does this PR solve the problem?
resolve blockers to enable DCE (deadcode elimination)
Pass grpcnotrace tag to remove x/net/trace dependency in grpc dependency causing DCE to be disabled
How to test this PR locally
run
make local
fleet-server binary size:
35M -> 23M
Design Checklist
Checklist
./changelog/fragments
using the changelog toolRelated issues
This is an automatic backport of pull request #4784 done by [Mergify](https://mergify.com).