Skip to content

[8.17](backport #4784) fix: add grpcnotrace to go build tags #4824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 8.17
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 17, 2025

What is the problem this PR solves?

DCE is disabled in fleet-server

How does this PR solve the problem?

resolve blockers to enable DCE (deadcode elimination)

Pass grpcnotrace tag to remove x/net/trace dependency in grpc dependency causing DCE to be disabled

How to test this PR locally

run make local

fleet-server binary size:

35M -> 23M

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues


This is an automatic backport of pull request #4784 done by [Mergify](https://mergify.com).

* fix: add grpcnotrace to go build tags

resolve blockers to enable DCE (deadcode elimination)

Pass grpcnotrace tag to remove x/net/trace dependency in grpc
dependency causing DCE to be disabled

fleet-server binary size (make local):

35M -> 23M

* changelog: add fragment

(cherry picked from commit 6c35557)

# Conflicts:
#	Makefile
@mergify mergify bot requested a review from a team as a code owner April 17, 2025 22:53
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Apr 17, 2025
@mergify mergify bot requested review from swiatekm and pchila April 17, 2025 22:53
Copy link
Contributor Author

mergify bot commented Apr 17, 2025

Cherry-pick of 6c35557 has failed:

On branch mergify/bp/8.17/pr-4784
Your branch is up to date with 'origin/8.17'.

You are currently cherry-picking commit 6c35557.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   changelog/fragments/1744852233-enable-dce.yaml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   Makefile

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Apr 17, 2025
8 tasks
Copy link
Contributor Author

mergify bot commented Apr 21, 2025

This pull request has not been merged yet. Could you please review and merge it @kruskall? 🙏

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Apr 22, 2025
@michel-laterman
Copy link
Contributor

The PRs that added gobuildtags were related to FIPS and was not backported to 8.17, @ebeahan do we want to add the other changes needed to backport this?

Copy link
Contributor Author

mergify bot commented Apr 28, 2025

This pull request has not been merged yet. Could you please review and merge it @kruskall? 🙏

2 similar comments
Copy link
Contributor Author

mergify bot commented May 5, 2025

This pull request has not been merged yet. Could you please review and merge it @kruskall? 🙏

Copy link
Contributor Author

mergify bot commented May 12, 2025

This pull request has not been merged yet. Could you please review and merge it @kruskall? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants