-
Notifications
You must be signed in to change notification settings - Fork 93
[8.19](backport #4544) Add BUILDKITE_ANALYTICS_TOKEN in fips-e2e-test step #4935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 8.19
Are you sure you want to change the base?
Conversation
(cherry picked from commit 2c04d3d) # Conflicts: # .buildkite/hooks/pre-command
Cherry-pick of 2c04d3d has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
let's backport this - so we can avoid issues in the future with the merge conflicts 🙇 |
|
What is the problem this PR solves?
Set BUILDKITE_ANALYTICS_TOKEN for FIPS E2E test step. Without this env var FIPS E2E step will break on CI
// Please do not just reference an issue. Explain WHAT the problem this PR solves here.
How does this PR solve the problem?
Include FIPS E2E test step to the list of steps for which BUILDKITE_ANALYTICS_TOKEN will be set in pre-command hook.
// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.
How to test this PR locally
Design Checklist
[ ] I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.[ ] I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.[ ] I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragments
using the changelog toolRelated issues
This is an automatic backport of pull request #4544 done by [Mergify](https://mergify.com).