Skip to content

[8.19](backport #4544) Add BUILDKITE_ANALYTICS_TOKEN in fips-e2e-test step #4935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 8.19
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 19, 2025

What is the problem this PR solves?

Set BUILDKITE_ANALYTICS_TOKEN for FIPS E2E test step. Without this env var FIPS E2E step will break on CI
// Please do not just reference an issue. Explain WHAT the problem this PR solves here.

How does this PR solve the problem?

Include FIPS E2E test step to the list of steps for which BUILDKITE_ANALYTICS_TOKEN will be set in pre-command hook.
// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.

How to test this PR locally

Design Checklist

  • [ ] I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • [ ] I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • [ ] I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool

Related issues


This is an automatic backport of pull request #4544 done by [Mergify](https://mergify.com).

(cherry picked from commit 2c04d3d)

# Conflicts:
#	.buildkite/hooks/pre-command
@mergify mergify bot requested a review from a team as a code owner May 19, 2025 17:59
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels May 19, 2025
@mergify mergify bot requested review from blakerouse and pkoutsovasilis May 19, 2025 17:59
Copy link
Contributor Author

mergify bot commented May 19, 2025

Cherry-pick of 2c04d3d has failed:

On branch mergify/bp/8.19/pr-4544
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 2c04d3d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .buildkite/hooks/pre-command

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@prodsecmachine
Copy link

prodsecmachine commented May 19, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@github-actions github-actions bot added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team ci CI related tasks labels May 19, 2025
@v1v
Copy link
Member

v1v commented May 19, 2025

let's backport this - so we can avoid issues in the future with the merge conflicts 🙇

@v1v v1v removed the conflicts There is a conflict in the backported pull request label May 19, 2025
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci CI related tasks Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants