add topologySpreadConstraints #1514
Conversation
- add topologySpreadConstraints to the logstash statefulSets - added supporting values to values.yaml with in-line doc link. - Added and ran templating test - Added value to the chart README.
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist. |
|
This PR has been automatically closed because it has not had recent activity since being marked as stale. Please reopen when work resumes. |
| @@ -115,6 +115,15 @@ spec: | |||
| podAffinity: | |||
| {{ toYaml . | indent 10 }} | |||
| {{- end }} | |||
| {{- if .Values.topologySpreadConstraints.enabled }} | |||
| topologySpreadConstraints: | |||
| - maxSkew: {{ .Values.topologySpreadConstraints.maxSkew }} | |||
There was a problem hiding this comment.
@jgregmac this should be a loop to allow for more than one constraint.
There was a problem hiding this comment.
@cdenneen This recommendation has been implemented in my fork, although I do not see that change reflected in the "changed files" view of this PR. The recent merge from master is reflected in the commit history though, so I am puzzled by that. Perhaps I need to file a new PR?
There was a problem hiding this comment.
Maybe new PR is necessary and looks like bumping Chart is necessary requirement too.
|
@jmlrt allowing issues and PRs to auto stale/close isn't really helpful. @jgregmac Possibly need to handle multiple like this: spec:
topologySpreadConstraints:
- maxSkew: 1
topologyKey: "topology.kubernetes.io/zone"
whenUnsatisfiable: ScheduleAnyway
labelSelector:
matchLabels:
dev: jjones
- maxSkew: 1
topologyKey: "kubernetes.io/hostname"
whenUnsatisfiable: ScheduleAnyway
labelSelector:
matchLabels:
dev: jjones
- maxSkew: 1
topologyKey: "karpenter.sh/capacity-type"
whenUnsatisfiable: ScheduleAnyway
labelSelector:
matchLabels:
dev: jjones |
|
@jgregmac please rebase |
PR supports feature requested here: #1513