Skip to content

feat: [mysql] add support for condition #12881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: [mysql] add support for condition #12881

wants to merge 4 commits into from
+41 −4

Conversation

BenB196
Copy link
Contributor

@BenB196 BenB196 commented Feb 24, 2025

Enhancement

Proposed commit message

  • WHAT: Adds condition support
  • WHY: Allows for conditionally specifying when integration runs

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
    - [ ] I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@BenB196 BenB196 requested a review from a team as a code owner February 24, 2025 19:15
Linu-Elias
Linu-Elias approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@Linu-Elias Linu-Elias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor comments given.

@andrewkroh andrewkroh added Integration:mysql MySQL Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Mar 13, 2025
@BenB196
Copy link
Contributor Author

BenB196 commented Mar 24, 2025

Bumping this so it doesn't go stale

@ishleenk17
Copy link
Contributor

/test

@elasticmachine
Copy link

elasticmachine commented Mar 25, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@BenB196
Copy link
Contributor Author

BenB196 commented Apr 16, 2025

Hi, I see that the pipeline failed, but I don't think its related to this change, is there anything preventing this PR from being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linu-Elias Linu-Elias Linu-Elias approved these changes

@ishleenk17 ishleenk17 ishleenk17 approved these changes

Assignees
No one assigned
Labels
Integration:mysql MySQL Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BenB196 @ishleenk17 @elasticmachine @Linu-Elias @andrewkroh