Skip to content

#11767 - Remove deprecated httpjson from packages zeek, apache, system, windows, aws.cloudtrail and nginx #13246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

#11767 - Remove deprecated httpjson from packages zeek, apache, system, windows, aws.cloudtrail and nginx #13246

wants to merge 7 commits into from
+40 −4,462

Conversation

qcorporation
Copy link
Contributor

@qcorporation qcorporation commented Mar 21, 2025 •
edited
Loading

Parent Ticket

#11767

Proposed commit message

Remove httpjson from packages zeek, apache, system, windows, aws.cloudtrail and nginx

  • removed docker service if applicable
  • removed system tests if they use the httpjson input that's been deprecated
  • removed httpjson input from the manifest file
  • update each integration to a new major version as this can potentially be a breaking change

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Ran system and pipeline test and validated no failures

Exceptions

There is still the windows integration where all the system tests are based upon the httpjson input
Speaking with the teams with code ownership to get recommendations

Screenshots

Screenshot 2025-03-21 at 3 24 56 PM
Screenshot 2025-03-21 at 3 03 27 PM
Screenshot 2025-03-21 at 2 49 48 PM
Screenshot 2025-03-21 at 2 11 15 PM

@qcorporation
Remove httpjson from packages zeek, apache, system and nginx
9a1ea02 
- removed docker service if applicable
- removed pipeline tests if they use the httpjson input that's been deprecated
- update each integration to a new major version as this can potentially be a breaking change
@qcorporation qcorporation added Integration:system System Integration:apache Apache HTTP Server Integration:zeek Zeek Integration:nginx Nginx Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform] labels Mar 21, 2025
@qcorporation qcorporation self-assigned this Mar 21, 2025
@qcorporation qcorporation changed the title #11767 - Remove httpjson from packages zeek, apache, system and nginx #11767 - Remove deprecated httpjson from packages zeek, apache, system and nginx Mar 21, 2025
@qcorporation qcorporation added Team:Service-Integrations Label for the Observability Service Integrations team Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] and removed Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Service-Integrations Label for the Observability Service Integrations team labels Mar 21, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Mar 21, 2025 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@qcorporation
removing splunk httpjson support for windows
868cdea 
- removed docker deployment
- removed manifest configuration
- remove system test configuration
@qcorporation qcorporation marked this pull request as ready for review March 25, 2025 19:52
@qcorporation qcorporation requested review from a team as code owners March 25, 2025 19:52
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elasticmachine
Copy link

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@elasticmachine
Copy link

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

leehinman
leehinman requested changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just think there is one more file that can be removed.

P1llus
P1llus reviewed Mar 25, 2025
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the actions performed here, but I did not review if any additional files needed to be removed

@muthu-mps
Copy link
Contributor

@qcorporation - The changelog entry for the windows integrations is missing. As this is considered as a breaking change, Can we add changelog entry with a major version upgrade?

@muthu-mps muthu-mps changed the title #11767 - Remove deprecated httpjson from packages zeek, apache, system and nginx #11767 - Remove deprecated httpjson from packages zeek, apache, system, windows and nginx Mar 26, 2025
@qcorporation
addressed PR comments
50844c6 
added change log and include new version within manifest.yml for windows
removed security.stream.yml as it's not needed
@qcorporation
Copy link
Contributor Author

qcorporation commented Mar 26, 2025 •
edited
Loading

@qcorporation - The changelog entry for the windows integrations is missing. As this is considered as a breaking change, Can we add changelog entry with a major version upgrade?

@muthu-mps thanks for catching this. I realized that I missed this after my EOD. fixed

@qcorporation qcorporation requested a review from leehinman March 26, 2025 18:54
@qcorporation qcorporation requested review from a team as code owners March 27, 2025 14:23
efd6
efd6 reviewed Mar 27, 2025
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add aws to the list of packages in the commit message.

@qcorporation qcorporation changed the title #11767 - Remove deprecated httpjson from packages zeek, apache, system, windows and nginx #11767 - Remove deprecated httpjson from packages zeek, apache, system, windows, aws.cloudtrail and nginx Mar 27, 2025
@qcorporation
Copy link
Contributor Author

Please add aws to the list of packages in the commit message.

@efd6 good catch, I've updated the proposed commit message and PR title. thanks for the suggestion

efd6
efd6 approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws changes LGTM

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @qcorporation

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
55.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

muthu-mps
muthu-mps approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS Cloudtrail integration is exceptional in upgrading to major release version.
Code owner approval!

marc-gr
marc-gr approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@marc-gr marc-gr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus left review comments

@marc-gr marc-gr marc-gr approved these changes

@nicholasberlin nicholasberlin nicholasberlin approved these changes

@leehinman leehinman leehinman approved these changes

@efd6 efd6 efd6 approved these changes

@taylor-swanson taylor-swanson taylor-swanson approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

@khushijain21 khushijain21 Awaiting requested review from khushijain21 khushijain21 is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@qcorporation qcorporation

Labels
Integration:apache Apache HTTP Server Integration:aws AWS Integration:nginx Nginx Integration:system System Integration:windows Windows Integration:zeek Zeek Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Windows Platform Security Windows Platform team [elastic/sec-windows-platform]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@qcorporation @elasticmachine @muthu-mps @P1llus @marc-gr @nicholasberlin @leehinman @efd6 @taylor-swanson @andrewkroh