-
Notifications
You must be signed in to change notification settings - Fork 451
[cisco_ise] Add Support of Timezone Configuration Parameter #13540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
changes: | ||
- description: Add support of timezone in configuration parameter. | ||
type: enhancement | ||
link: https://github.com/elastic/integrations/pull/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link: https://github.com/elastic/integrations/pull/1 | |
link: https://github.com/elastic/integrations/pull/13540 |
- rename: | ||
field: _conf.tz_offset | ||
target_field: event.timezone | ||
if: ctx._conf?.tz_offset != null | ||
tag: rename_tz_offset | ||
ignore_missing: true | ||
- rename: | ||
field: _tmp.timezone | ||
tag: rename_tmp_timezone | ||
target_field: event.timezone | ||
if: ctx.event?.timezone == null # If user has not provided the timezone offset. | ||
ignore_missing: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this will give the configuration priority over a time zone seen in a log, is this intended behavior? In other Cisco integrations, the priority is log, then configuration.
Should we reverse the order here so the log time zone is given priority and if it isn't present, then we use the time zone from configuration?
Proposed Commit Message
Checklist
changelog.yml
file.How to test this PR locally
Clone integrations repo.
Install the elastic package locally.
Start the elastic stack using the elastic package.
Move to integrations/packages/cisco_ise directory.
Run the following command to run tests.
elastic-package test -v
Related issues
It closes issue #24307 from the enhancements repo.