[rapid7_insightvm] Add nested fields to asset and asset_vulnerability data streams#17833
[rapid7_insightvm] Add nested fields to asset and asset_vulnerability data streams#17833brijesh-elastic wants to merge 2 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Vale Linting ResultsSummary: 4 warnings found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/rapid7_insightvm/docs/README.md | 263 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/rapid7_insightvm/docs/README.md | 265 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/rapid7_insightvm/docs/README.md | 548 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/rapid7_insightvm/docs/README.md | 550 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
efd6
left a comment
There was a problem hiding this comment.
This is the implementation that the user asked for. An alternative would be to construct a map of name to type, but I think risks clobbering data if the same name appears twice, and if a user wants that behaviour it is easy to implement in a @custom pipeline.
| @@ -252,10 +261,14 @@ An example event for `asset` looks as following: | |||
| | rapid7.insightvm.asset.severe_vulnerabilities | The count of severe vulnerability findings. | long | | |||
| | rapid7.insightvm.asset.tags.name | The stored value. | keyword | | |||
| | rapid7.insightvm.asset.tags.type | The type of information stored and displayed. For sites, the value is "SITE". | keyword | | |||
| | rapid7.insightvm.asset.tags_nested.name | The stored value. | keyword | | |||
| | rapid7.insightvm.asset.tags_nested.type | The type of information stored and displayed. For sites, the value is "SITE". | keyword | | |||
There was a problem hiding this comment.
I disagree with the Vale linter here; in normal English punctuation rules, what it says is correct, but in the context of quoting a value that is a string literal it is heading for confused users.
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related issues