Skip to content

feat(contextual-security-apps): replace title props and wrap EuiButtonIcon with EuiToolTip#271473

Open
weronikaolejniczak wants to merge 5 commits into
elastic:mainfrom
weronikaolejniczak:feat/replace-title-contextual-security-apps
Open

feat(contextual-security-apps): replace title props and wrap EuiButtonIcon with EuiToolTip#271473
weronikaolejniczak wants to merge 5 commits into
elastic:mainfrom
weronikaolejniczak:feat/replace-title-contextual-security-apps

Conversation

@weronikaolejniczak
Copy link
Copy Markdown
Contributor

@weronikaolejniczak weronikaolejniczak commented May 27, 2026

Relates to elastic/eui#9566

Important

These changes should be carefully tested visually by each code owner. Wrapping with EuiToolTip instead of passing title leads to another DOM node and can potentially break the layout. In such cases, I would appreciate committing appropriate fixes to this PR directly, I cannot possibly setup and run all Kibana functionalities to fix every regression.

This PR:

  • wraps ALL EuiButtonIcon with EuiToolTip, the content is the same as aria-label, any title passed to EuiButtonIcon is removed,
  • changes several title cases (not truncation related) to use EuiToolTip instead (if applicable).

@weronikaolejniczak weronikaolejniczak added backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes labels May 27, 2026
@weronikaolejniczak
Copy link
Copy Markdown
Contributor Author

buildkite test this

@alexwizp alexwizp added backport:version Backport to applied version labels v9.5.0 v9.4.2 and removed backport:skip This PR does not require backporting labels May 28, 2026
@alexwizp
Copy link
Copy Markdown
Contributor

/ci

@weronikaolejniczak weronikaolejniczak marked this pull request as ready for review May 28, 2026 14:23
@weronikaolejniczak weronikaolejniczak requested a review from a team as a code owner May 28, 2026 14:23
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/eui-team (EUI)

@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #189 / Cloud Security Posture - Group 5 (KSPM + Flyouts) Security Alerts Page - Graph visualization expanded flyout - filter by node
  • [job] [logs] FTR Configs #162 / Dashboard dashboard in space Storing search sessions in space Saves and restores a session
  • [job] [logs] FTR Configs #202 / Entity Analytics - Watchlists @ess @serverless @skipInServerlessMKI Entity Store Attribute Sync should remove the watchlist id from entity.attributes.watchlists on deletion but preserve other ids

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 616.4KB 617.0KB +629.0B
securitySolution 12.1MB 12.1MB +1.3KB
sessionView 357.1KB 357.7KB +613.0B
total +2.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
sessionView 43.0KB 43.3KB +313.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels EUI release_note:skip Skip the PR/issue when compiling release notes v9.4.2 v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants