[EuiToolTip] Replace all title attributes with EuiToolTip#268225
Closed
weronikaolejniczak wants to merge 7 commits into
Closed
[EuiToolTip] Replace all title attributes with EuiToolTip#268225weronikaolejniczak wants to merge 7 commits into
weronikaolejniczak wants to merge 7 commits into
Conversation
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
weronikaolejniczak
force-pushed
the
feat/replace-title
branch
3 times, most recently
from
dde016d to
2f4a574
Compare
|
Hi @weronikaolejniczak , does this PR also addresses #270154? I noticed that it covered #270161 and I was wondering if you are improving it across the whole platform? |
Contributor
Author
|
@miguel-sanchez-elastic that's the goal, to improve it across the whole platform (as much as possible). EUI components have been addressed here, this PR is for Kibana specific cases like wrapping all I'll link this one as well. If you know of any other cases, feel free to drop them here! |
weronikaolejniczak
added
release_note:skip
…ally, or add an exception to src/dev/yarn_deduplicate/index.ts and then commit the changes and push to your branch
…long with `label` in `IconButtonGroup`
weronikaolejniczak
force-pushed
the
feat/replace-title
branch
from
15d7d39 to
4efdf63
Compare
Contributor
💔 Build Failed
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
|
Contributor
Author
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relates to elastic/eui#9643
Closes elastic/eui#9566
Closes #270161
Closes #270154
Important
These changes should be carefully tested visually by each code owner. Wrapping with
EuiToolTipinstead of passingtitleleads to another DOM node and can potentially break the layout. In such cases, I would appreciate committing appropriate fixes to this PR directly, I cannot possibly setup and run all Kibana functionalities to fix every regression.This PR:
EuiButtonIconwithEuiToolTip, the content is the same asaria-label, anytitlepassed toEuiButtonIconis removed,titlecases (not truncation related) to useEuiToolTipinstead.Requested changes
These are the specific places that were requested either in GitHub (see the linked issues) or through Slack:
Issue #270161 (Metrics in Discover) - addressed
EuiToolTipinsearch_button.tsxEuiToolTipinuse_fullscreen.tsxIssue #270154 (Discover viz Edit/Save) - addressed
toolTipContentto theIconButtonGroupaction inchart.tsx:284(bothcanEditVisualizationOnTheFlyandonEditVisualizationbranches)toolTipContentto theIconButtonGroupaction inchart.tsx:308Issue image case ("Send to background") - addressed
tooltipPropsonEuiSplitButton.ActionSecondaryinquery_bar_top_row.tsx:875tooltipPropsonEuiSplitButton.ActionSecondaryinquery_bar_top_row.tsx:971QA
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
Documentation was added for features that require explanation or tutorialsIf a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listThis was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. Therelease_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.