Skip to content

feat(kibana-presentation): replace title props and wrap EuiButtonIcon with EuiToolTip#271486

Open
weronikaolejniczak wants to merge 5 commits into
elastic:mainfrom
weronikaolejniczak:feat/replace-title-kibana-presentation
Open

feat(kibana-presentation): replace title props and wrap EuiButtonIcon with EuiToolTip#271486
weronikaolejniczak wants to merge 5 commits into
elastic:mainfrom
weronikaolejniczak:feat/replace-title-kibana-presentation

Conversation

@weronikaolejniczak
Copy link
Copy Markdown
Contributor

@weronikaolejniczak weronikaolejniczak commented May 27, 2026

Relates to elastic/eui#9566

Important

These changes should be carefully tested visually by each code owner. Wrapping with EuiToolTip instead of passing title leads to another DOM node and can potentially break the layout. In such cases, I would appreciate committing appropriate fixes to this PR directly, I cannot possibly setup and run all Kibana functionalities to fix every regression.

This PR:

  • wraps ALL EuiButtonIcon with EuiToolTip, the content is the same as aria-label, any title passed to EuiButtonIcon is removed,
  • changes several title cases (not truncation related) to use EuiToolTip instead (if applicable).

@weronikaolejniczak weronikaolejniczak added backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes labels May 27, 2026
@weronikaolejniczak
Copy link
Copy Markdown
Contributor Author

buildkite test this

@weronikaolejniczak weronikaolejniczak self-assigned this May 28, 2026
@weronikaolejniczak weronikaolejniczak marked this pull request as ready for review May 28, 2026 07:39
@weronikaolejniczak weronikaolejniczak requested a review from a team as a code owner May 28, 2026 07:39
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/eui-team (EUI)

@botelastic botelastic Bot added Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame labels May 28, 2026
@alexwizp alexwizp added backport:version Backport to applied version labels v9.5.0 v9.4.2 and removed backport:skip This PR does not require backporting labels May 28, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / ActionPolicyFormPage create mode submits create payload on save

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.1MB 1.1MB +629.0B
controls 528.0KB 528.4KB +318.0B
cps 13.7KB 13.8KB +77.0B
dashboard 1.1MB 1.1MB +380.0B
embeddable 90.0KB 90.1KB +136.0B
inputControlVis 41.8KB 42.4KB +576.0B
inspector 31.8KB 32.5KB +725.0B
maps 3.2MB 3.2MB +1.5KB
unifiedSearch 315.1KB 315.4KB +305.0B
total +4.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kql 13.8KB 13.9KB +77.0B

History

cc @weronikaolejniczak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels EUI Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes v9.4.2 v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants