Skip to content

[9.4] feat(kibana-data-discovery): replace title props and wrap EuiButtonIcon with EuiToolTip (#271481)#271895

Open
alexwizp wants to merge 3 commits into
elastic:9.4from
alexwizp:backport/9.4/pr-271481
Open

[9.4] feat(kibana-data-discovery): replace title props and wrap EuiButtonIcon with EuiToolTip (#271481)#271895
alexwizp wants to merge 3 commits into
elastic:9.4from
alexwizp:backport/9.4/pr-271481

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp commented May 29, 2026

Backport

This will backport the following commits from main to 9.4:

Questions ?

Please refer to the Backport tool documentation

@weronikaolejniczak
feat(kibana-data-discovery): replace title props and wrap EuiButtonIc…
2daea52 
…on with EuiToolTip (elastic#271481)

Closes elastic#270161

Relates to elastic/eui#9566

> [!IMPORTANT]
> These changes **should be carefully tested visually by each code
owner.** Wrapping with `EuiToolTip` instead of passing `title` leads to
another DOM node and can potentially break the layout. In such cases, I
would appreciate committing appropriate fixes to this PR directly, I
cannot possibly setup and run all Kibana functionalities to fix every
regression.

This PR:

- wraps ALL `EuiButtonIcon` with `EuiToolTip`, the content is the same
as `aria-label`, any `title` passed to `EuiButtonIcon` is removed,
- changes several `title` cases (not truncation related) to use
`EuiToolTip` instead (if applicable).

---------

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
Co-authored-by: Ania Kowalska <63072419+akowalska622@users.noreply.github.com>
(cherry picked from commit 5993118)

# Conflicts:
#	src/platform/packages/shared/kbn-unified-histogram/components/chart/chart.tsx
@alexwizp alexwizp requested a review from kibanamachine as a code owner May 29, 2026 11:35
@alexwizp alexwizp added the backport This PR is a backport of another PR label May 29, 2026
@alexwizp alexwizp enabled auto-merge (squash) May 29, 2026 11:35
@alexwizp alexwizp mentioned this pull request May 29, 2026
Merged
@kibanamachine kibanamachine requested review from akowalska622 and removed request for kibanamachine May 29, 2026 11:35
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 1, 2026 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / AppMenuActionButton should not call secondary run when split button secondary is disabled
  • [job] [logs] Jest Tests #5 / AppMenuActionButton should not call secondary run when split button secondary is disabled
  • [job] [logs] FTR Configs #39 / Cloud Security Posture - Group 5 (KSPM + Flyouts) Security Alerts Page - Graph visualization expanded flyout - filter by node
  • [job] [logs] FTR Configs #62 / dashboard app - group 4 dashboard listing page edit meta data saves changes to dashboard metadata
  • [job] [logs] FTR Configs #62 / dashboard app - group 4 dashboard listing page edit meta data saves changes to dashboard metadata
  • [job] [logs] FTR Configs #129 / dashboard app - group 5 dashboard settings should warn when creating a duplicate title
  • [job] [logs] FTR Configs #129 / dashboard app - group 5 dashboard settings should warn when creating a duplicate title
  • [job] [logs] FTR Configs #18 / Dashboard Session and searches integration until session is saved search keepAlive is short, when it is saved, keepAlive is extended and search is saved into the session saved object, when session is extended, searches are also extended
  • [job] [logs] FTR Configs #18 / Dashboard Session and searches integration until session is saved search keepAlive is short, when it is saved, keepAlive is extended and search is saved into the session saved object, when session is extended, searches are also extended
  • [job] [logs] Scout Lane #10 - stateful-classic / default / local-stateful-classic - Observability Landing Page (discover.isEsqlDefault enabled) - redirects to onboarding when no logs data exists

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
alertingVTwo 628.7KB 629.0KB +298.0B
cloudSecurityPosture 613.5KB 613.8KB +298.0B
core 135.8KB 135.9KB +57.0B
dataViewFieldEditor 102.1KB 102.6KB +535.0B
dataViewManagement 145.5KB 145.9KB +437.0B
discover 1.9MB 1.9MB +633.0B
esql 889.3KB 889.6KB +298.0B
esqlDataGrid 153.7KB 154.0KB +298.0B
lens 2.1MB 2.1MB +114.0B
osquery 1.3MB 1.3MB +298.0B
securitySolution 12.0MB 12.0MB +298.0B
slo 1.1MB 1.1MB +298.0B
unifiedDocViewer 679.2KB 679.3KB +73.0B
unifiedSearch 155.5KB 155.5KB +57.0B
total +3.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
navigation 10.7KB 10.8KB +57.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akowalska622 akowalska622 akowalska622 approved these changes

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexwizp @kibanamachine @akowalska622 @weronikaolejniczak