Skip to content

[9.4] feat(kibana-data-discovery): replace title props and wrap EuiButtonIcon with EuiToolTip (#271481) #271895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexwizp wants to merge 3 commits into
base: 9.4
Choose a base branch
from
Open

[9.4] feat(kibana-data-discovery): replace title props and wrap EuiButtonIcon with EuiToolTip (#271481) #271895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2daea52
feat(kibana-data-discovery): replace title props and wrap EuiButtonIc…
weronikaolejniczak May 29, 2026
3bfceae
Merge branch '9.4' into backport/9.4/pr-271481
alexwizp May 29, 2026
22526df
Merge branch '9.4' into backport/9.4/pr-271481
alexwizp Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions src/platform/packages/private/kbn-split-button/src/split_button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* License v3.0 only", or the "Server Side Public License, v 1".
*/

import { EuiButton, EuiButtonIcon, useEuiTheme } from '@elastic/eui';
import { EuiButton, EuiButtonIcon, EuiToolTip, useEuiTheme } from '@elastic/eui';
import type { EuiButtonProps, IconType, UseEuiTheme } from '@elastic/eui';
import { useMemoCss } from '@kbn/css-utils/public/use_memo_css';
import React from 'react';
Expand Down Expand Up @@ -81,19 +81,20 @@ export const SplitButton = ({
) : (
<EuiButton iconType={iconType} {...commonMainButtonProps} />
)}
<EuiButtonIcon
css={styles.secondaryButton}
data-test-subj={mainButtonProps['data-test-subj'] + `-secondary-button`}
aria-label={secondaryButtonAriaLabel}
display={secondaryButtonFill ? 'fill' : 'base'}
title={secondaryButtonTitle}
color={color}
size={size}
iconType={secondaryButtonIcon}
onClick={onSecondaryButtonClick}
isDisabled={areButtonsDisabled || isSecondaryButtonDisabled}
isLoading={isLoading || isSecondaryButtonLoading}
/>
<EuiToolTip content={secondaryButtonTitle} disableScreenReaderOutput>
<EuiButtonIcon
css={styles.secondaryButton}
data-test-subj={mainButtonProps['data-test-subj'] + `-secondary-button`}
aria-label={secondaryButtonAriaLabel}
display={secondaryButtonFill ? 'fill' : 'base'}
color={color}
size={size}
iconType={secondaryButtonIcon}
onClick={onSecondaryButtonClick}
isDisabled={areButtonsDisabled || isSecondaryButtonDisabled}
isLoading={isLoading || isSecondaryButtonLoading}
/>
</EuiToolTip>
</div>
);
};
Expand Down
120 changes: 70 additions & 50 deletions ...hared/kbn-data-grid-in-table-search/src/__snapshots__/in_table_search_input.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 31 additions & 16 deletions src/platform/packages/shared/kbn-data-grid-in-table-search/src/in_table_search_input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
EuiFlexGroup,
EuiFlexItem,
EuiText,
EuiToolTip,
keys,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
Expand Down Expand Up @@ -119,28 +120,42 @@ export const InTableSearchInput: React.FC<InTableSearchInputProps> = React.memo(
</EuiText>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonIcon
iconType="chevronSingleUp"
color="text"
data-test-subj={BUTTON_PREV_TEST_SUBJ}
disabled={areArrowsDisabled}
aria-label={i18n.translate('dataGridInTableSearch.buttonPreviousMatch', {
<EuiToolTip
content={i18n.translate('dataGridInTableSearch.buttonPreviousMatch', {
defaultMessage: 'Previous',
})}
onClick={goToPrevMatch}
/>
disableScreenReaderOutput
>
<EuiButtonIcon
iconType="chevronSingleUp"
color="text"
data-test-subj={BUTTON_PREV_TEST_SUBJ}
disabled={areArrowsDisabled}
aria-label={i18n.translate('dataGridInTableSearch.buttonPreviousMatch', {
defaultMessage: 'Previous',
})}
onClick={goToPrevMatch}
/>
</EuiToolTip>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonIcon
iconType="chevronSingleDown"
color="text"
data-test-subj={BUTTON_NEXT_TEST_SUBJ}
disabled={areArrowsDisabled}
aria-label={i18n.translate('dataGridInTableSearch.buttonNextMatch', {
<EuiToolTip
content={i18n.translate('dataGridInTableSearch.buttonNextMatch', {
defaultMessage: 'Next',
})}
onClick={goToNextMatch}
/>
disableScreenReaderOutput
>
<EuiButtonIcon
iconType="chevronSingleDown"
color="text"
data-test-subj={BUTTON_NEXT_TEST_SUBJ}
disabled={areArrowsDisabled}
aria-label={i18n.translate('dataGridInTableSearch.buttonNextMatch', {
defaultMessage: 'Next',
})}
onClick={goToNextMatch}
/>
</EuiToolTip>
</EuiFlexItem>
</EuiFlexGroup>
}
Expand Down
24 changes: 15 additions & 9 deletions src/platform/packages/shared/kbn-unified-histogram/components/chart/chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,31 +268,37 @@ export function UnifiedHistogramChart({
const actions: IconButtonGroupProps['buttons'] = [];

if (canEditVisualizationOnTheFly) {
const editLabel = i18n.translate('unifiedHistogram.editVisualizationButton', {
defaultMessage: 'Edit visualization',
});
actions.push({
label: i18n.translate('unifiedHistogram.editVisualizationButton', {
defaultMessage: 'Edit visualization',
}),
label: editLabel,
toolTipContent: editLabel,
iconType: 'pencil',
isDisabled: isFlyoutVisible,
'data-test-subj': 'unifiedHistogramEditFlyoutVisualization',
onClick: () => setIsFlyoutVisible(true),
});
} else if (onEditVisualization) {
const editLabel = i18n.translate('unifiedHistogram.editVisualizationButton', {
defaultMessage: 'Edit visualization',
});
actions.push({
label: i18n.translate('unifiedHistogram.editVisualizationButton', {
defaultMessage: 'Edit visualization',
}),
label: editLabel,
toolTipContent: editLabel,
iconType: 'lensApp',
'data-test-subj': 'unifiedHistogramEditVisualization',
onClick: onEditVisualization,
});
}

if (canSaveVisualization) {
const saveLabel = i18n.translate('unifiedHistogram.saveVisualizationButton', {
defaultMessage: 'Save visualization to dashboard',
});
actions.push({
label: i18n.translate('unifiedHistogram.saveVisualizationButton', {
defaultMessage: 'Save visualization to dashboard',
}),
label: saveLabel,
toolTipContent: saveLabel,
iconType: 'dashboardApp',
'data-test-subj': 'unifiedHistogramSaveVisualization',
onClick: () => setIsSaveModalVisible(true),
Expand Down
40 changes: 21 additions & 19 deletions src/platform/packages/shared/kbn-unified-tabs/src/hooks/use_responsive_tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*/

import React, { useCallback, useEffect, useMemo, useState } from 'react';
import { EuiButtonIcon, useEuiTheme, useResizeObserver } from '@elastic/eui';
import { EuiButtonIcon, EuiToolTip, useEuiTheme, useResizeObserver } from '@elastic/eui';
import { throttle } from 'lodash';
import { i18n } from '@kbn/i18n';
import { css } from '@emotion/react';
Expand Down Expand Up @@ -97,31 +97,33 @@ export const useResponsiveTabs = ({
const scrollLeftButton = useMemo(
() =>
tabsSizeConfig.isScrollable ? (
<EuiButtonIcon
data-test-subj="unifiedTabs_tabsBar_scrollLeftBtn"
iconType="chevronSingleLeft"
color="text"
disabled={scrollState?.isScrollableLeft === false}
aria-label={scrollLeftButtonLabel}
title={scrollLeftButtonLabel}
onClick={scrollLeft}
/>
<EuiToolTip content={scrollLeftButtonLabel} disableScreenReaderOutput>
<EuiButtonIcon
data-test-subj="unifiedTabs_tabsBar_scrollLeftBtn"
iconType="chevronSingleLeft"
color="text"
disabled={scrollState?.isScrollableLeft === false}
aria-label={scrollLeftButtonLabel}
onClick={scrollLeft}
/>
</EuiToolTip>
) : null,
[scrollLeftButtonLabel, scrollLeft, tabsSizeConfig.isScrollable, scrollState?.isScrollableLeft]
);

const scrollRightButton = useMemo(
() =>
tabsSizeConfig.isScrollable ? (
<EuiButtonIcon
data-test-subj="unifiedTabs_tabsBar_scrollRightBtn"
iconType="chevronSingleRight"
color="text"
disabled={scrollState?.isScrollableRight === false}
aria-label={scrollRightButtonLabel}
title={scrollRightButtonLabel}
onClick={scrollRight}
/>
<EuiToolTip content={scrollRightButtonLabel} disableScreenReaderOutput>
<EuiButtonIcon
data-test-subj="unifiedTabs_tabsBar_scrollRightBtn"
iconType="chevronSingleRight"
color="text"
disabled={scrollState?.isScrollableRight === false}
aria-label={scrollRightButtonLabel}
onClick={scrollRight}
/>
</EuiToolTip>
) : null,
[
scrollRightButtonLabel,
Expand Down
Loading
Loading