Skip to content

[Security Solution] [Onboarding] Integrations tab separators not showing on dark mode #210380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 14, 2025
Merged

[Security Solution] [Onboarding] Integrations tab separators not showing on dark mode #210380

merged 6 commits into from
Feb 14, 2025
+51 −1

Conversation

@agusruidiazgd
Copy link
Contributor

@agusruidiazgd agusruidiazgd commented Feb 10, 2025 •
edited
Loading

Summary

This PR addresses #208986

Screen.Recording.2025-02-10.at.14.17.14.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@agusruidiazgd agusruidiazgd added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore ci:cloud-deploy Create or update a Cloud deployment backport:version Backport to applied version labels EUI Visual Refresh labels Feb 10, 2025
@agusruidiazgd agusruidiazgd self-assigned this Feb 10, 2025
@agusruidiazgd agusruidiazgd requested a review from a team as a code owner February 10, 2025 13:46
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 10, 2025

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@agusruidiazgd
Copy link
Contributor Author

agusruidiazgd commented Feb 10, 2025

@elasticmachine merge upstream

kapral18
kapral18 reviewed Feb 13, 2025
View reviewed changes
...blic/onboarding/components/onboarding_body/cards/integrations/integration_card_grid_tabs.tsx
const { spaceId } = useOnboardingContext();
const scrollElement = useRef<HTMLDivElement>(null);
const { euiTheme, colorMode } = useEuiTheme();
const isDark = colorMode === COLOR_MODES_STANDARD.dark;
Copy link
Contributor

@kapral18 kapral18 Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to know 👍

kapral18
kapral18 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@kapral18 kapral18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 nit. Thanks

@agusruidiazgd
Copy link
Contributor Author

agusruidiazgd commented Feb 14, 2025

@elasticmachine merge upstream

@agusruidiazgd agusruidiazgd enabled auto-merge (squash) February 14, 2025 12:56
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 14, 2025 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 7081 7082 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.9MB 8.9MB +489.0B

History

cc @agusruidiazgd

@agusruidiazgd agusruidiazgd merged commit 0c8685f into elastic:main Feb 14, 2025
9 checks passed
@kibanamachine kibanamachine added v9.1.0 backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 14, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 17, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally

5 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 18, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 19, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 20, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 21, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 24, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 24, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

29 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 25, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 26, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 29, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 30, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 1, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 2, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 3, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 6, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 7, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 8, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 9, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 10, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 13, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 14, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 15, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 16, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 17, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 20, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 21, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 22, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 23, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 24, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 27, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 29, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 30, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 31, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 3, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 4, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 5, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 210380 locally
cc: @agusruidiazgd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kapral18 kapral18 kapral18 approved these changes

Assignees

@agusruidiazgd agusruidiazgd

Labels

backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels ci:cloud-deploy Create or update a Cloud deployment EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v8.19.0 v9.0.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agusruidiazgd @elasticmachine @kibanamachine @kapral18