[9.0] [Security Solution] Fix redux action being fired because of unused react-router value (#217055)#218456
Merged
Conversation
…act-router value (elastic#217055) ## Summary This pr fixes a bug with the RouteCapture component, used at a high level in the security solution component tree, to reflect url changes into redux. The code previously used the full result of 'react-router-dom' 's useLocation hook as the payload, which contains 4 parameters, pathname, search, hash that we make use of, and a 4th that was added sometime later by the library that is essentially a random id generated every time the hook is called, called key. We have never used this, and it was being inadvertently copied into the redux state, and also causing some other actions or hooks based listeners to run I think as well. Below is the contrived example of going from the home page to an empty alerts page, and you can see 4 actions in the after, and 5 in the before, with 1 updating only the key. May reduce more unneeded actions with more going on in the page, but exactly how many is not known. Before:  After:  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit c277812)
Merged
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation