Skip to content

[9.0][Search] fix: incorrect docs explorer paging result#234168

Merged
seialkali merged 2 commits into
elastic:9.0from
seialkali:fix/incorrect-paging-display
Oct 10, 2025
Merged

[9.0][Search] fix: incorrect docs explorer paging result#234168
seialkali merged 2 commits into
elastic:9.0from
seialkali:fix/incorrect-paging-display

Conversation

@seialkali
Copy link
Copy Markdown
Contributor

Summary

Fixes incorrect paging info display in the Docs Explorer when an attached index has no documents. Previously, the view showed Showing 1-0 of 0. After updating @elastic/search-ui and related packagesto^1.24.0, the view correctly displays Showing 0-0 of 0`.

Testing

  1. Go to search applications
  2. Create an application with an index that has no documents
  3. Go to the details page for application
  4. On the Docs Explorer you should see the correct display for the paging info view: Showing 0-0 of 0

Before

Screenshot 2025-09-05 at 11 10 21

After

Screenshot 2025-09-05 at 12 32 18

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Release note

Fixes an issue in the Docs Explorer where the paging info displayed incorrectly when the attached index had no documents. After updating @elastic/search-ui and related packages to ^1.24.0, the view now shows the correct result count.

@seialkali seialkali added release_note:fix Team:Search backport:version Backport to applied version labels v9.0.7 v8.18.7 v8.19.4 backport This PR is a backport of another PR and removed backport:version Backport to applied version labels v8.18.7 v8.19.4 labels Sep 5, 2025
@sphilipse sphilipse added backport:skip This PR does not require backporting and removed backport This PR is a backport of another PR labels Sep 29, 2025
@seialkali seialkali added backport This PR is a backport of another PR and removed release_note:fix backport:skip This PR does not require backporting Team:Search v9.0.7 labels Oct 10, 2025
@seialkali seialkali force-pushed the fix/incorrect-paging-display branch from d561297 to 90bce05 Compare October 10, 2025 10:20
@seialkali seialkali force-pushed the fix/incorrect-paging-display branch from 97ab5fd to a028ffe Compare October 10, 2025 10:45
Copy link
Copy Markdown
Contributor

@yansavitski yansavitski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seialkali seialkali enabled auto-merge (squash) October 10, 2025 10:48
@seialkali seialkali merged commit 5da52a3 into elastic:9.0 Oct 10, 2025
8 of 9 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #62 / Space awareness agents POST /agents/bulkUpdateAgentTags should only update tags of agents in the same space when passing a kuery

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1263 1112 -151

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.3MB 1.3MB +2.3KB
logsExplorer 204.9KB 204.9KB -4.0B
observabilityOnboarding 251.8KB 251.0KB -809.0B
total +1.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
enterpriseSearch 38.8KB 39.2KB +444.0B
kbnUiSharedDeps-npmDll 6.1MB 6.1MB -12.0B
logsShared 146.0KB 146.0KB -2.0B
total +430.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants