Skip to content

[Security Solution] [AI assistant] Hide the default llm and default llm only settings from advanced setting#238086

Closed
KDKHD wants to merge 2 commits into
elastic:9.0from
KDKHD:bug/remove-default-llm-advanced-settings
Closed

[Security Solution] [AI assistant] Hide the default llm and default llm only settings from advanced setting#238086
KDKHD wants to merge 2 commits into
elastic:9.0from
KDKHD:bug/remove-default-llm-advanced-settings

Conversation

@KDKHD
Copy link
Copy Markdown
Member

@KDKHD KDKHD commented Oct 8, 2025

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

This PR ensures the genAi default LLM settings do not appear within advanced settings. The settings should only appear within the AI assistant pages.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@KDKHD
Copy link
Copy Markdown
Member Author

KDKHD commented Oct 8, 2025

/ci

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #12 / Saved objects management should be able to handle multi-space imports correctly imported dashboard into another space should render correctly

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAiAssistantManagement 134.5KB 134.4KB -122.0B
securitySolution 8.9MB 8.9MB -126.0B
total -248.0B

@KDKHD KDKHD changed the title hide the default llm and default llm only settings from advanced sett… [Security Solution] [AI assistant] Hide the default llm and default llm only settings from advanced setting Oct 9, 2025
@KDKHD KDKHD marked this pull request as ready for review October 9, 2025 14:59
@KDKHD KDKHD requested a review from kibanamachine as a code owner October 9, 2025 14:59
@KDKHD KDKHD added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI backport:version Backport to applied version labels v8.18.9 v8.19.6 labels Oct 9, 2025
@KDKHD
Copy link
Copy Markdown
Member Author

KDKHD commented Oct 15, 2025

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

CI was triggered for this PR, but this PR targets 9.0 which should not receive a future release. CI is not supported for these branches. Please consult the release schedule, or contact #kibana-operations if you believe this is an error.

The following branches are currently considered to be open:

  • main
  • 9.2
  • 9.1
  • 8.19
  • 8.18
  • 7.17

1 similar comment
@elasticmachine
Copy link
Copy Markdown
Contributor

CI was triggered for this PR, but this PR targets 9.0 which should not receive a future release. CI is not supported for these branches. Please consult the release schedule, or contact #kibana-operations if you believe this is an error.

The following branches are currently considered to be open:

  • main
  • 9.2
  • 9.1
  • 8.19
  • 8.18
  • 7.17

@KDKHD KDKHD closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI v8.18.9 v8.19.6

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants