[Lens] move reference handling to server#239029
Merged
Merged
Conversation
nickofthyme
added
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
nickofthyme
commented
Oct 21, 2025
dej611
approved these changes
Oct 23, 2025
Contributor
dej611
left a comment
dej611
left a comment
There was a problem hiding this comment.
Tested locally and works fine.
Left some minor comments, in particular about type locations.
Will approve to unblock.
This comment was marked as resolved.
This comment was marked as resolved.
nreese
reviewed
Oct 27, 2025
elastic-vault-github-plugin-prod
Bot
requested a review
from a team
as a code owner
nickofthyme
commented
Oct 29, 2025
bg sessions use the public url transforms which defaults to references from the dashboard url which are now always empty, soon to be removed entirely. But in Lens we had logic to filter references from the dashboard based on references from the lens SO. Instead we should just merge all refs from the lens SO and dashboard.
Contributor
💛 Build succeeded, but was flakyFailed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
History
|
nickofthyme
commented
Oct 30, 2025
Comment on lines
+412
to
+414
| // TODO: Improve these types | ||
| const lensVis = vis as unknown as LensEmbeddableStateWithType; | ||
| return extract(lensVis).references; |
Contributor
Author
There was a problem hiding this comment.
The types here are complaining because vis.attributes are Record<string, unknown>.
ana-davydova
pushed a commit
to ana-davydova/kibana
that referenced
this pull request
Nov 3, 2025
## Summary Move Lens `reference` handling to server side. Close elastic#221943 ## Details Lens no longer relies on `references` from the `buildEmbeddable`. We now inject/extract references on the server. Lens duplicates `references` in it's own serialized state so we just move them there and add the `savedObjectId` for by-ref Lens panels. Lens still inject these `references` internally by type across the Lens code. For now we still store the `references` duplicated in the Lens SO state, but we can clean this up when we extract all the internal reference handling. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Marco Liberati <dej611@users.noreply.github.com> Co-authored-by: dej611 <dej611@gmail.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
albertoblaz
pushed a commit
to albertoblaz/kibana
that referenced
this pull request
Nov 4, 2025
## Summary Move Lens `reference` handling to server side. Close elastic#221943 ## Details Lens no longer relies on `references` from the `buildEmbeddable`. We now inject/extract references on the server. Lens duplicates `references` in it's own serialized state so we just move them there and add the `savedObjectId` for by-ref Lens panels. Lens still inject these `references` internally by type across the Lens code. For now we still store the `references` duplicated in the Lens SO state, but we can clean this up when we extract all the internal reference handling. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Marco Liberati <dej611@users.noreply.github.com> Co-authored-by: dej611 <dej611@gmail.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move Lens
referencehandling to server side.Close #221943
Details
Lens no longer relies on
referencesfrom thebuildEmbeddable. We now inject/extract references on the server.Lens duplicates
referencesin it's own serialized state so we just move them there and add thesavedObjectIdfor by-ref Lens panels. Lens still inject thesereferencesinternally by type across the Lens code.For now we still store the
referencesduplicated in the Lens SO state, but we can clean this up when we extract all the internal reference handling.Checklist
backport:*labels.