[Lens] Infinite reference accumulation

[nickofthyme]

Summary

Fixes issue where Lens panels on a dashboard that have no references, like a vis with ad-hoc dataview (i.e. ES|QL), will blindly add dashboard references. But these references are not always panel-specific thus lens will absorb all dashboard references.

Details

In #239029 we moved the lens references to the server and passed them in the SO under attributes.references until the references can be properly injected into the state itself.

Previously we were filtering the panel references from the dashboard with the references from attributes.references. But with the transforms now being run on the client side code, the dashboard references can be empty, see #239029 (comment). Thus we need to merge these two reference sources.

kibana/x-pack/platform/plugins/shared/lens/common/embeddable_factory/index.ts

Lines 31 to 46 in b8f3c71

	// match references based on name, so only references associated with this lens panel are injected.
	const matchedReferences: Reference[] = [];
	if (Array.isArray(typedState.attributes.references)) {
	typedState.attributes.references.forEach((serializableRef) => {
	const internalReference = serializableRef;
	const matchedReference = references.find(
	(reference) => reference.name === internalReference.name
	);
	if (matchedReference) matchedReferences.push(matchedReference);
	});
	}
	typedState.attributes.references = matchedReferences;
	return typedState as unknown as EmbeddableStateWithType;

But additionally, the dashboard may pass the transformOut method all the unfiltered raw references when the filter references are empty.

kibana/src/platform/plugins/shared/dashboard/server/api/transforms/out/transform_panels_out.ts

Line 36 in 440e3d5

const panelReferences = filteredReferences.length === 0 ? references : filteredReferences;

The solution is to treat the lens attributes.references as the source of truth and only use the dashboard panel references to update the id on matching references by name and type.

fixes #245283

Checklist

• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
• The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
• Review the backport guidelines and apply applicable backport:* labels.

[elasticmachine]

Pinging @elastic/kibana-visualizations (Team:Visualizations)

[nreese]

LGTM - thanks for removing dashboard specific reference name logic.

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: aaca1b4

Failed CI Steps

• FTR Configs #39
• FTR Configs #141

Test Failures

• [job] [logs] FTR Configs #39 / serverless search UI - search features Search Playground - Saved Playgrounds Update Saved Playground should allow updating playground name
• [job] [logs] FTR Configs #141 / Standard Product intercept page transitions transitions from one tab to another and back again will cause the intercept to be displayed if the intercept interval has elapsed on transitioning

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
lens	1.6MB	1.6MB	+78.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
lens	22	23	+1

Total ESLint disabled count

id	before	after	diff
lens	22	23	+1

History

• 💔 Build #371975 failed c7201fc
• 💔 Build #369710 failed 66aa602