Skip to content

[Security Solution] cleanup types for row actions#240185

Merged
PhilippeOberti merged 2 commits into
elastic:mainfrom
PhilippeOberti:action-row-type-cleanup
Nov 13, 2025
Merged

[Security Solution] cleanup types for row actions#240185
PhilippeOberti merged 2 commits into
elastic:mainfrom
PhilippeOberti:action-row-type-cleanup

Conversation

@PhilippeOberti
Copy link
Copy Markdown
Contributor

@PhilippeOberti PhilippeOberti commented Oct 22, 2025

Summary

While working on some Timeline pinned event performance improvements (see this draft PR), I noticed a piece of code related to some table row actions types that could be improved.

This PR makes a small modification to the code, to make it more clear which types are used in specific row action related components.

Important

Code changes should have zero impact on the UI!

Checklist

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@PhilippeOberti PhilippeOberti force-pushed the action-row-type-cleanup branch 2 times, most recently from b471c7a to 5b8487c Compare October 30, 2025 03:30
@PhilippeOberti PhilippeOberti force-pushed the action-row-type-cleanup branch 2 times, most recently from c4a0b68 to 5774885 Compare October 30, 2025 19:17
@PhilippeOberti PhilippeOberti force-pushed the action-row-type-cleanup branch from 5774885 to 3d63ae0 Compare November 7, 2025 16:07
@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v9.3.0 labels Nov 7, 2025
@PhilippeOberti PhilippeOberti marked this pull request as ready for review November 11, 2025 17:26
@PhilippeOberti PhilippeOberti requested review from a team as code owners November 11, 2025 17:26
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

Copy link
Copy Markdown
Contributor

@janmonschke janmonschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-cases changes lgtm

@PhilippeOberti PhilippeOberti enabled auto-merge (squash) November 13, 2025 04:21
@PhilippeOberti PhilippeOberti merged commit 4ec366e into elastic:main Nov 13, 2025
12 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.0MB 11.0MB -498.0B

History

@PhilippeOberti PhilippeOberti deleted the action-row-type-cleanup branch November 13, 2025 17:22
eokoneyo pushed a commit to eokoneyo/kibana that referenced this pull request Dec 2, 2025
## Summary

While working on some Timeline pinned event performance improvements
(see [this draft PR](elastic#242304)), I
noticed a piece of code related to some table row actions types that
could be improved.

This PR makes a small modification to the code, to make it more clear
which types are used in specific row action related components.


> [!IMPORTANT]
> Code changes should have zero impact on the UI!

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

Co-authored-by: Matthew Wilde <matt.wilde@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants