[Security Solution] cleanup types for row actions#240185
Merged
PhilippeOberti merged 2 commits intoNov 13, 2025
Merged
Conversation
b471c7a to
5b8487c
Compare
c4a0b68 to
5774885
Compare
5774885 to
3d63ae0
Compare
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
janmonschke
approved these changes
Nov 12, 2025
Contributor
janmonschke
left a comment
There was a problem hiding this comment.
kibana-cases changes lgtm
nkhristinin
approved these changes
Nov 12, 2025
kqualters-elastic
approved these changes
Nov 13, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI Steps
Metrics [docs]Async chunks
History
|
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
## Summary While working on some Timeline pinned event performance improvements (see [this draft PR](elastic#242304)), I noticed a piece of code related to some table row actions types that could be improved. This PR makes a small modification to the code, to make it more clear which types are used in specific row action related components. > [!IMPORTANT] > Code changes should have zero impact on the UI! ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. Co-authored-by: Matthew Wilde <matt.wilde@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While working on some Timeline pinned event performance improvements (see this draft PR), I noticed a piece of code related to some table row actions types that could be improved.
This PR makes a small modification to the code, to make it more clear which types are used in specific row action related components.
Important
Code changes should have zero impact on the UI!
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.