[9.1] @kbn/storage-adapter: do not update settings when updating mappings (#232840)#240194
Merged
Merged
Conversation
…elastic#232840) ## Summary Fix a bug causing a mapping update of a `index-storage` to cause an error during `updateMappingsOfExistingIndex`. During that phase, we were trying to update the index's settings in addition to its mappings. However, the `simulateIndexTemplate` API returns the full set of settings, and not only the ones which can be updated, so the following `putSettings` call was failing with errors such as: ``` Root causes: illegal_argument_exception: can not update private setting [index.allocation.existing_shards_allocator]; this setting is managed by Elasticsearch ``` Given there is apparently no proper way to identify which setting(s) are private vs which ones can be updated, this PR simply fully disables the setting update part, as discussed with @elastic/kibana-core. (cherry picked from commit 55c1587)
Contributor
💚 Build Succeeded
Metrics [docs]
|
gsoldevila
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.1:@kbn/storage-adapter: do not update settings when updating mappings (#232840)Questions ?
Please refer to the Backport tool documentation