Skip to content

Fix usage counter test in 9.0 #241250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jesuswr wants to merge 1 commit into from
Closed

Fix usage counter test in 9.0 #241250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions test/plugin_functional/test_suites/usage_collection/usage_counters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { PluginFunctionalProviderContext } from '../../services';

export default function ({ getService, getPageObjects }: PluginFunctionalProviderContext) {
const supertest = getService('supertest');
const retry = getService('retry');

async function getSavedObjectCounters() {
// wait until ES indexes the counter SavedObject;
Expand All @@ -39,7 +40,7 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide
}

// Failing: See https://github.com/elastic/kibana/issues/238414
describe.skip('Usage Counters service', () => {
describe('Usage Counters service', () => {
before(async () => {
const key = serializeCounterKey({
domainId: 'usageCollectionTestPlugin',
Expand All @@ -60,10 +61,21 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide
});

it('stores usage counters triggered by runtime activities', async () => {
// Pull initial values
const initialCounters = await getSavedObjectCounters();
const initialRouteAccessed = initialCounters.routeAccessed || 0;
expect(initialRouteAccessed).to.be(0);

// Send the request
await supertest.get('/api/usage_collection_test_plugin').set('kbn-xsrf', 'true').expect(200);

const { routeAccessed } = await getSavedObjectCounters();
expect(routeAccessed).to.be(1);
// Check routeAccessed counter was updated
let routeAccessed: number | undefined;
await retry.waitFor('routeAccessed counter is incremented', async () => {
({ routeAccessed } = await getSavedObjectCounters());
return routeAccessed !== undefined && routeAccessed > initialRouteAccessed;
});
expect(routeAccessed).to.be(initialRouteAccessed + 1);
});
});
}