Skip to content

[9.0] Catch connector errors but do not interrupt the case creation flow (#244188) #244225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kibanamachine wants to merge 1 commit into from
Closed

[9.0] Catch connector errors but do not interrupt the case creation flow (#244188) #244225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions x-pack/platform/plugins/shared/cases/public/components/create/form_context.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,6 +1047,43 @@ describe('Create case', () => {
).toBe(true);
});

it('should succeed even when pushing to an external service fails', async () => {
const failPushCaseToExternalService = jest.fn().mockRejectedValue(new Error('Push failed'));
usePostPushToServiceMock.mockImplementation(() => ({
isLoading: false,
isError: false,
mutateAsync: failPushCaseToExternalService,
}));

renderWithTestingProviders(
<FormContext
selectedOwner={SECURITY_SOLUTION_OWNER}
onSuccess={onFormSubmitSuccess}
afterCaseCreated={afterCaseCreated}
currentConfiguration={currentConfiguration}
>
<CreateCaseFormFields {...defaultCreateCaseForm} connectors={connectorsMock} />
<SubmitCaseButton />
</FormContext>
);

await waitForFormToRender();
await fillFormReactTestingLib({ user });

await user.click(screen.getByTestId('dropdown-connectors'));

await waitFor(() => {
expect(screen.getByTestId('dropdown-connector-resilient-2')).toBeInTheDocument();
});

await user.click(screen.getByTestId('dropdown-connector-resilient-2'));
await user.click(screen.getByTestId('create-case-submit'));

await waitFor(() => {
expect(onFormSubmitSuccess).toHaveBeenCalled();
});
});

describe('Permissions', () => {
it('should not push to service if the user does not have access to actions', async () => {
const coreStart = coreMock.createStart();
Expand Down
16 changes: 12 additions & 4 deletions x-pack/platform/plugins/shared/cases/public/components/create/form_context.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,18 @@ export const FormContext: React.FC<Props> = ({
}

if (theCase?.id && data.connector.id !== 'none') {
await pushCaseToExternalService({
caseId: theCase.id,
connector: data.connector,
});
try {
await pushCaseToExternalService({
caseId: theCase.id,
connector: data.connector,
});
} catch (error) {
// Catch the error but do not interrupt the flow.
// The case has been created successfully at this point.
// The only thing that failed was pushing to the external service.
// Changes to the connector fields can be made later on by the user.
// They will be notified about the connector failure.
}
}

if (onSuccess && theCase) {
Expand Down