[Unified Data Table] Split test into 3 smaller tests#245045
Merged
AlexGPlay merged 1 commit intoDec 3, 2025
Merged
Conversation
AlexGPlay
added
release_note:skip
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
cc @AlexGPlay |
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
NicholasPeretti
approved these changes
Dec 3, 2025
Contributor
NicholasPeretti
left a comment
NicholasPeretti
left a comment
There was a problem hiding this comment.
Nice refactor! Thank you for this
Contributor
|
Let's backport to 9.2 as it fails sometimes there too. |
AlexGPlay
added
backport:version
Contributor
|
Starting backport for target branches: 9.2 |
Contributor
|
Starting backport for target branches: 9.2 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
AlexGPlay
added a commit
to AlexGPlay/kibana
that referenced
this pull request
Dec 4, 2025
## Summary Closes elastic#234829 Right now we have the `should show the reset width button only for absolute width columns, and allow resetting to default width` test that is asserting 3 different things: - When resetting the width of the time column from absolute it goes back to the default - When resetting the width of a column that isn't the time column from absolute it goes back to the default - A column without absolute width can't be reset This means that we can split the test into 3 smaller and more focused tests for each of those scenarios. This should help with the timeout as we are no longer waiting for a big one. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit f7266e7) # Conflicts: # src/platform/packages/shared/kbn-unified-data-table/src/components/data_table.test.tsx
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
AlexGPlay
added a commit
that referenced
this pull request
Dec 5, 2025
…245200) # Backport This will backport the following commits from `main` to `9.2`: - [[Unified Data Table] Split test into 3 smaller tests (#245045)](#245045) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alejandro García Parrondo","email":"31973472+AlexGPlay@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-12-03T15:25:03Z","message":"[Unified Data Table] Split test into 3 smaller tests (#245045)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/234829\n\nRight now we have the `should show the reset width button only for\nabsolute width columns, and allow resetting to default width` test that\nis asserting 3 different things:\n- When resetting the width of the time column from absolute it goes back\nto the default\n- When resetting the width of a column that isn't the time column from\nabsolute it goes back to the default\n- A column without absolute width can't be reset\n\nThis means that we can split the test into 3 smaller and more focused\ntests for each of those scenarios. This should help with the timeout as\nwe are no longer waiting for a big one.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"f7266e765f0eafdb5548fd1e2ac845b8dd5658fa","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:version","v9.2.0","v9.3.0"],"title":"[Unified Data Table] Split test into 3 smaller tests","number":245045,"url":"https://github.com/elastic/kibana/pull/245045","mergeCommit":{"message":"[Unified Data Table] Split test into 3 smaller tests (#245045)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/234829\n\nRight now we have the `should show the reset width button only for\nabsolute width columns, and allow resetting to default width` test that\nis asserting 3 different things:\n- When resetting the width of the time column from absolute it goes back\nto the default\n- When resetting the width of a column that isn't the time column from\nabsolute it goes back to the default\n- A column without absolute width can't be reset\n\nThis means that we can split the test into 3 smaller and more focused\ntests for each of those scenarios. This should help with the timeout as\nwe are no longer waiting for a big one.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"f7266e765f0eafdb5548fd1e2ac845b8dd5658fa"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/245045","number":245045,"mergeCommit":{"message":"[Unified Data Table] Split test into 3 smaller tests (#245045)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/234829\n\nRight now we have the `should show the reset width button only for\nabsolute width columns, and allow resetting to default width` test that\nis asserting 3 different things:\n- When resetting the width of the time column from absolute it goes back\nto the default\n- When resetting the width of a column that isn't the time column from\nabsolute it goes back to the default\n- A column without absolute width can't be reset\n\nThis means that we can split the test into 3 smaller and more focused\ntests for each of those scenarios. This should help with the timeout as\nwe are no longer waiting for a big one.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"f7266e765f0eafdb5548fd1e2ac845b8dd5658fa"}}]}] BACKPORT-->
kibanamachine
added
v9.2.3
and removed
backport missing
JordanSh
pushed a commit
to JordanSh/kibana
that referenced
this pull request
Dec 9, 2025
## Summary Closes elastic#234829 Right now we have the `should show the reset width button only for absolute width columns, and allow resetting to default width` test that is asserting 3 different things: - When resetting the width of the time column from absolute it goes back to the default - When resetting the width of a column that isn't the time column from absolute it goes back to the default - A column without absolute width can't be reset This means that we can split the test into 3 smaller and more focused tests for each of those scenarios. This should help with the timeout as we are no longer waiting for a big one. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #234829
Right now we have the
should show the reset width button only for absolute width columns, and allow resetting to default widthtest that is asserting 3 different things:This means that we can split the test into 3 smaller and more focused tests for each of those scenarios. This should help with the timeout as we are no longer waiting for a big one.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelinesbackport:*labels.