Skip to content

[9.1] improve reporting error logging (#244841) #245499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ersin-erdal merged 5 commits into from
Dec 9, 2025
Merged

[9.1] improve reporting error logging (#244841) #245499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2632340
improve reporting error logging (#244841)
ersin-erdal Dec 8, 2025
b14bd99
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine Dec 8, 2025
bdb85aa
remove redundant files
ersin-erdal Dec 8, 2025
cb982a5
fix syntax
ersin-erdal Dec 8, 2025
c9043cc
fix check type
ersin-erdal Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 74 additions & 39 deletions src/platform/packages/private/kbn-generate-csv/src/generate_csv.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ const createMockJob = (baseObj: Partial<JobParamsCSV> = {}): JobParamsCSV =>
} as JobParamsCSV);
const mockTaskInstanceFields = { startedAt: null, retryAt: null };

const jobId = 'mock-job-id';

describe('CsvGenerator', () => {
let mockEsClient: IScopedClusterClient;
let mockDataClient: ISearchClient;
Expand Down Expand Up @@ -182,7 +184,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);
const csvResult = await generateCsv.generateData();
expect(content).toMatchSnapshot();
Expand Down Expand Up @@ -219,7 +222,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);
const csvResult = await generateCsv.generateData();
expect(content).toMatchSnapshot();
Expand Down Expand Up @@ -259,7 +263,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);
const csvResult = await generateCsv.generateData();
expect(csvResult.max_size_reached).toBe(false);
Expand Down Expand Up @@ -310,7 +315,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);
const csvResult = await generateCsv.generateData();
expect(csvResult.max_size_reached).toBe(true);
Expand Down Expand Up @@ -369,7 +375,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);
const csvResult = await generateCsv.generateData();
expect(csvResult.warnings).toEqual([]);
Expand Down Expand Up @@ -449,7 +456,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);
await generateCsv.generateData();
expect(content).toMatchSnapshot();
Expand Down Expand Up @@ -479,7 +487,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);

await expect(generateCsv.generateData()).resolves.toMatchInlineSnapshot(`
Expand Down Expand Up @@ -530,7 +539,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);

await generateCsv.generateData();
Expand Down Expand Up @@ -566,7 +576,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);

await generateCsv.generateData();
Expand Down Expand Up @@ -664,7 +675,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
).generateData();

await jest.advanceTimersByTimeAsync(timeFromNowInMs);
Expand Down Expand Up @@ -748,7 +760,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
).generateData();

await jest.advanceTimersByTimeAsync(requestDuration);
Expand Down Expand Up @@ -837,7 +850,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);
const csvResult = await generateCsv.generateData();
expect(csvResult.max_size_reached).toBe(true);
Expand All @@ -862,7 +876,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);
const csvResult = await generateCsv.generateData();
expect(csvResult.warnings).toEqual([]);
Expand Down Expand Up @@ -933,7 +948,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);
await generateCsv.generateData();
expect(content).toMatchSnapshot();
Expand Down Expand Up @@ -971,7 +987,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);

await generateCsv.generateData();
Expand All @@ -997,7 +1014,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);

await generateCsv.generateData();
Expand Down Expand Up @@ -1038,7 +1056,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);
await generateCsv.generateData();

Expand Down Expand Up @@ -1086,7 +1105,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);

const csvResult = await generateCsv.generateData();
Expand Down Expand Up @@ -1141,7 +1161,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);

const csvResult = await generateCsv.generateData();
Expand Down Expand Up @@ -1184,7 +1205,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);
await generateCsv.generateData();

Expand Down Expand Up @@ -1223,7 +1245,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);
await generateCsv.generateData();

Expand Down Expand Up @@ -1262,7 +1285,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);
await generateCsv.generateData();

Expand Down Expand Up @@ -1303,7 +1327,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);

const csvResult = await generateCsv.generateData();
Expand Down Expand Up @@ -1342,7 +1367,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);

const csvResult = await generateCsv.generateData();
Expand Down Expand Up @@ -1386,7 +1412,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);

const csvResult = await generateCsv.generateData();
Expand Down Expand Up @@ -1416,7 +1443,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);

await generateCsv.generateData();
Expand Down Expand Up @@ -1474,7 +1502,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);
await expect(generateCsv.generateData()).resolves.toMatchInlineSnapshot(`
Object {
Expand All @@ -1496,10 +1525,12 @@ describe('CsvGenerator', () => {
expect(mockLogger.error.mock.calls).toMatchInlineSnapshot(`
Array [
Array [
"CSV export search error: ResponseError: my error",
],
Array [
[ResponseError: my error],
[ResponseError: CSV export search error: my error],
Object {
"tags": Array [
"mock-job-id",
],
},
],
]
`);
Expand All @@ -1525,7 +1556,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);

await expect(generateCsv.generateData()).resolves.toMatchInlineSnapshot(`
Expand All @@ -1540,7 +1572,7 @@ describe('CsvGenerator', () => {
},
},
"warnings": Array [
"Encountered an unknown error: An unknown error",
"Encountered an unknown error: CSV export search error: An unknown error",
"Encountered an error with the number of CSV rows generated from the search: expected rows were indeterminable, received 0.",
],
}
Expand All @@ -1552,7 +1584,7 @@ describe('CsvGenerator', () => {
],
Array [
"
\\"Encountered an unknown error: An unknown error\\"
\\"Encountered an unknown error: CSV export search error: An unknown error\\"
\\"Encountered an error with the number of CSV rows generated from the search: expected rows were indeterminable, received 0.\\"",
],
]
Expand Down Expand Up @@ -1598,7 +1630,8 @@ describe('CsvGenerator', () => {
},
new CancellationToken(),
mockLogger,
stream
stream,
jobId
);

const { error_code: errorCode, warnings } = await generateCsv.generateData();
Expand All @@ -1613,10 +1646,12 @@ describe('CsvGenerator', () => {
expect(mockLogger.error.mock.calls).toMatchInlineSnapshot(`
Array [
Array [
"CSV export search error: ResponseError: Response Error",
],
Array [
[ResponseError: Response Error],
[ResponseError: CSV export search error: Response Error],
Object {
"tags": Array [
"mock-job-id",
],
},
],
]
`);
Expand Down
Loading