[Chrome Next] AppMenu changes for DnD#259949
Conversation
## Summary This PR removes `AppMenuConfigNext` as we'll be modifying `AppMenuConfig` and going straight to main with it (#259949)
6f436aa to
3787640
Compare
689091b to
bb54dcf
Compare
bb54dcf to
2034455
Compare
4b03eee to
6bc8ac4
Compare
cf307c6 to
42d66eb
Compare
42d66eb to
37201c5
Compare
js-jankisalvi
left a comment
There was a problem hiding this comment.
response ops changes lgtm
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Public APIs missing exports
Unknown metric groupsAPI count
References to deprecated APIs
Unreferenced deprecated APIs
History
|
|
/flaky scoutConfig:x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts:25 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#11460
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#11460[✅] x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts: 25/25 tests passed. |
Summary
This PR updates app menu to match the first milestone of the new design from Project Vibranium (Chrome Next).
Changes:
secondaryActionItemfromAppMenuConfiginterface3:primaryActionItemis now treated separately and doesn't contribute to the limititemsis less or equal than3then all the items are visibleitemsis more than3then the overflow button will appear consuming one of the available slots, resulting in maximum of2items being visible alongside the overflow buttonThe changes affect both classic and solution views. The order of the items has been changed to match design decisions.
Visuals:
Implements: #259991