Skip to content

[Chrome Next] AppMenu changes for DnD#259949

Merged
kowalczyk-krzysztof merged 9 commits into
elastic:mainfrom
kowalczyk-krzysztof:feat/app-menu-chrome-next
Apr 8, 2026
Merged

[Chrome Next] AppMenu changes for DnD#259949
kowalczyk-krzysztof merged 9 commits into
elastic:mainfrom
kowalczyk-krzysztof:feat/app-menu-chrome-next

Conversation

@kowalczyk-krzysztof
Copy link
Copy Markdown
Member

@kowalczyk-krzysztof kowalczyk-krzysztof commented Mar 27, 2026

Summary

This PR updates app menu to match the first milestone of the new design from Project Vibranium (Chrome Next).

Changes:

  • removal of secondaryActionItem from AppMenuConfig interface
  • the number of items visible at once has been reduced to 3:
    • primaryActionItem is now treated separately and doesn't contribute to the limit
    • if the number of items is less or equal than 3 then all the items are visible
    • if the number of items is more than 3 then the overflow button will appear consuming one of the available slots, resulting in maximum of 2 items being visible alongside the overflow button

The changes affect both classic and solution views. The order of the items has been changed to match design decisions.

Visuals:

App Before After
Dashboards view mode Screenshot 2026-03-30 at 23 43 49 Screenshot 2026-03-30 at 23 51 35
Dashboards edit mode Screenshot 2026-03-30 at 23 43 42 Screenshot 2026-03-30 at 23 52 25
Discover KQL mode Screenshot 2026-03-30 at 23 45 12 Screenshot 2026-03-30 at 23 53 01
Discover ES|QL mode Screenshot 2026-03-30 at 23 45 26 Screenshot 2026-03-30 at 23 53 38

Implements: #259991

@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Mar 27, 2026
kowalczyk-krzysztof added a commit that referenced this pull request Mar 27, 2026
## Summary

This PR removes `AppMenuConfigNext` as we'll be modifying
`AppMenuConfig` and going straight to main with it
(#259949)
@kowalczyk-krzysztof kowalczyk-krzysztof force-pushed the feat/app-menu-chrome-next branch 2 times, most recently from 6f436aa to 3787640 Compare March 27, 2026 11:11
@kowalczyk-krzysztof kowalczyk-krzysztof added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Mar 27, 2026
@kowalczyk-krzysztof kowalczyk-krzysztof force-pushed the feat/app-menu-chrome-next branch 6 times, most recently from 689091b to bb54dcf Compare March 29, 2026 00:12
@kowalczyk-krzysztof kowalczyk-krzysztof force-pushed the feat/app-menu-chrome-next branch from bb54dcf to 2034455 Compare March 29, 2026 10:05
@kowalczyk-krzysztof kowalczyk-krzysztof force-pushed the feat/app-menu-chrome-next branch 4 times, most recently from 4b03eee to 6bc8ac4 Compare March 29, 2026 22:24
@kowalczyk-krzysztof kowalczyk-krzysztof added the Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// label Mar 29, 2026
@kowalczyk-krzysztof kowalczyk-krzysztof force-pushed the feat/app-menu-chrome-next branch 2 times, most recently from cf307c6 to 42d66eb Compare March 30, 2026 12:07
@kowalczyk-krzysztof kowalczyk-krzysztof force-pushed the feat/app-menu-chrome-next branch from 42d66eb to 37201c5 Compare March 30, 2026 20:27
@kowalczyk-krzysztof kowalczyk-krzysztof linked an issue Mar 30, 2026 that may be closed by this pull request
@kowalczyk-krzysztof kowalczyk-krzysztof marked this pull request as ready for review March 30, 2026 21:54
@kowalczyk-krzysztof kowalczyk-krzysztof requested review from a team as code owners March 30, 2026 21:54
Copy link
Copy Markdown
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread src/platform/test/functional/page_objects/dashboard_page.ts
Copy link
Copy Markdown
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response ops changes lgtm

@kowalczyk-krzysztof kowalczyk-krzysztof removed the request for review from dmlemeshko April 8, 2026 12:32
@kowalczyk-krzysztof kowalczyk-krzysztof enabled auto-merge (squash) April 8, 2026 12:33
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/core-chrome-app-menu-components 49 46 -3
@kbn/discover-utils 379 378 -1
total -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
core 84.5KB 83.6KB -961.0B
dashboard 866.8KB 866.8KB +14.0B
discover 1.6MB 1.6MB -1.2KB
total -2.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/core 995 994 -1
Unknown metric groups

API count

id before after diff
@kbn/core-chrome-app-menu-components 69 65 -4
@kbn/discover-utils 453 449 -4
total -8

References to deprecated APIs

id before after diff
@kbn/core 412 405 -7
dashboard 21 20 -1
discover 18 17 -1
total -9

Unreferenced deprecated APIs

id before after diff
@kbn/core 412 405 -7
dashboard 21 20 -1
discover 18 17 -1
total -9

History

cc @kowalczyk-krzysztof

@dmlemeshko
Copy link
Copy Markdown
Contributor

/flaky scoutConfig:x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts:25

@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#11460

  • x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts x25

@kowalczyk-krzysztof kowalczyk-krzysztof merged commit b1ee2f5 into elastic:main Apr 8, 2026
20 of 21 checks passed
@kowalczyk-krzysztof kowalczyk-krzysztof deleted the feat/app-menu-chrome-next branch April 8, 2026 15:02
@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#11460

[✅] x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel.playwright.config.ts: 25/25 tests passed.

see run history

This was referenced May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Vibranium][M1] Header: App menu integration

10 participants